Hey Leonard, Thanks for helping to verify the release. The 1.16.0 Flink version in the pom is a miss, ideally it should be updated to 1.18.0, additionally this should have been updated to 1.17.x previously. I would not consider it a hard blocker since the Maven build overrides this variable based on the provided -Dflink.version and the 1.17/1.18 binaries are valid. However it is non ideal that the default version in the source is outdated. Given that we are yet to receive any binding votes I am happy to spin an rc2 however am a bit busy this week at Flink Forward. I will consider this vote open for now unless you make your -1 binding.
Thanks, Danny On Tue, Nov 7, 2023 at 8:02 PM Leonard Xu <xbjt...@gmail.com> wrote: > Thanks Danny for driving this. I'm considering -1, please correct me if I > understand wrong. > > >> * The sources can be compiled and unit tests pass with flink.version > 1.17.1 > >> and flink.version 1.18.0 > >> > >> * Nexus has two staged artifact ids for 3.0.2-1.17 and 3.0.2-1.18 > >> - flink-connector-gcp-pubsub (.jar, -javadoc.jar, -sources.jar and .pom) > >> - flink-connector-gcp-pubsub-parent (only .pom) > > > This release aims to support Flink 1.17 and new released Flink 1.18，but > why is the version in pom file [1] still 1.16.0 ? IIUC, it should be > 1.17.0 according the process [2]. > > Best, > Leonard > > [1] > https://github.com/apache/flink-connector-gcp-pubsub/blob/v3.0.2-rc1/pom.xml#L51 > [1] > https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development > > > > 2023年11月7日 下午12:03，Samrat Deb <decordea...@gmail.com> 写道： > > > > +1(non-binding) > > > > - Checked release notes > > - Verified checksums and signatures > > - Verified no binaries in release > > - Build connector from source > > > > Bests, > > Samrat > > > > On Mon, 6 Nov 2023 at 8:20 PM, Ryan Skraba <ryan.skr...@aiven.io.invalid > > > > wrote: > > > >> Hello! +1 (non-binding) > >> > >> One note: the parent pom still has 1.16.0 for the Maven property of > >> flink.version for both 1.17 and 1.18 releases. > >> > >> I've validated the source for the RC1: > >> flink-connector-gcp-pubsub-3.0.2-src.tgz at r65060 > >> * The sha512 checksum is OK. > >> * The source file is signed correctly. > >> * The signature 0F79F2AFB2351BC29678544591F9C1EC125FD8DB is found in the > >> KEYS file, and on https://keyserver.ubuntu.com/ > >> * The source file is consistent with the GitHub tag v3.0.2-rc1, which > >> corresponds to commit 4c6be836e6c0f36ef5711f12d7b935254e7d248d > >> - The files explicitly excluded by create_pristine_sources (such as > >> .gitignore and the submodule tools/releasing/shared) are not present. > >> * Has a LICENSE file and a NOTICE file > >> * Does not contain any compiled binaries. > >> > >> > >> > >> I did a simple smoke test on an emulated Pub/Sub with the 1.18 version. > >> > >> All my best, Ryan Skraba > >> > >
