+1(non-binding)

- Checked release notes
- Verified checksums and signatures
- Verified no binaries in release
- Build connector from source

Bests,
Samrat

On Mon, 6 Nov 2023 at 8:20 PM, Ryan Skraba <ryan.skr...@aiven.io.invalid>
wrote:

> Hello! +1 (non-binding)
>
> One note: the parent pom still has 1.16.0 for the Maven property of
> flink.version for both 1.17 and 1.18 releases.
>
> I've validated the source for the RC1:
> flink-connector-gcp-pubsub-3.0.2-src.tgz at r65060
> * The sha512 checksum is OK.
> * The source file is signed correctly.
> * The signature 0F79F2AFB2351BC29678544591F9C1EC125FD8DB is found in the
> KEYS file, and on https://keyserver.ubuntu.com/
> * The source file is consistent with the GitHub tag v3.0.2-rc1, which
> corresponds to commit 4c6be836e6c0f36ef5711f12d7b935254e7d248d
> - The files explicitly excluded by create_pristine_sources (such as
> .gitignore and the submodule tools/releasing/shared) are not present.
> * Has a LICENSE file and a NOTICE file
> * Does not contain any compiled binaries.
>
> * The sources can be compiled and unit tests pass with flink.version 1.17.1
> and flink.version 1.18.0
>
> * Nexus has two staged artifact ids for 3.0.2-1.17 and 3.0.2-1.18
> - flink-connector-gcp-pubsub (.jar, -javadoc.jar, -sources.jar and .pom)
> - flink-connector-gcp-pubsub-parent (only .pom)
>
> I did a simple smoke test on an emulated Pub/Sub with the 1.18 version.
>
> All my best, Ryan Skraba
>

Reply via email to