Hi Martijn, Fair enough! Thanks for sharing the reference!
Best regards, Jing On Wed, Oct 18, 2023 at 9:43 AM Martijn Visser <martijnvis...@apache.org> wrote: > Hi Jing, > > Given that we as a Flink project decided to include compiled packages > in a release, they are part of the same release [1] and we vote on > both of them at the same time. > > Best regards, > > Martijn > > [1] https://www.apache.org/legal/release-policy.html#release-approval > > On Wed, Oct 18, 2023 at 9:21 AM Jing Ge <j...@ververica.com.invalid> > wrote: > > > > Hi Xianxun, > > > > Thanks for the feedback. May I know when you tested it? Could you please > > check which Java version is used to build the Flink you use? There was an > > update on 17th Oct. at 1:30pm. > > > > Best regards, > > Jing > > > > On Wed, Oct 18, 2023 at 4:32 AM Xianxun Ye <yesorno828...@gmail.com> > wrote: > > > > > Hi Jing, > > > > > > I also found the exception about the java.lang.NoSuchMethodError when I > > > ran the Kyuubi Flink Tests on Flink1.18-rc2. > > > > > > These are the steps, ran the below sql in the Flink SQL Client: > > > > > > create table tbl_src (a int) with ('connector' = 'datagen', > > > 'number-of-rows' = '100’); > > > > > > select count(a) from tbl_src; > > > > > > Could you also update flink1.18-rc2 bianry release[1] > > > > > > [1] https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc2/ > > > > > > Best regards, > > > Xianxun > > > > > > > 2023年10月18日 10:24，Yun Tang <myas...@live.com> 写道： > > > > > > > > Hi Jing, > > > > > > > > Thanks for the update, I checked the new maven repo, and the > artifacts > > > were built with JDK8 correctly. > > > > > > > > > > > > Best > > > > Yun Tang > > > > ________________________________ > > > > From: Jing Ge <j...@ververica.com.INVALID> > > > > Sent: Tuesday, October 17, 2023 23:31 > > > > To: dev@flink.apache.org <dev@flink.apache.org> > > > > Cc: Matthias Pohl <matthias.p...@aiven.io>; sergey.nuyan...@aiven.io > < > > > sergey.nuyan...@aiven.io> > > > > Subject: Re: [VOTE] Release 1.18.0, release candidate #2 > > > > > > > > Hi Yun, > > > > > > > > I have created a new maven repo[5]. Would you like to check it out? > > > Thanks > > > > for your support! Once I get your confirmation, I will start the > second > > > > voting thread with the title "[VOTE][2] Release 1.18.0, release > candidate > > > > #2", because the source code is not changed. > > > > > > > > All Devs: please ignore this thread. I will start a new one as I > > > > mentioned above. > > > > > > > > Best regards, > > > > Jing > > > > > > > > [5] > > > https://repository.apache.org/content/repositories/orgapacheflink-1659 > > > > > > > > On Tue, Oct 17, 2023 at 3:53 PM Jing Ge <j...@ververica.com> wrote: > > > > > > > >> Hi Yun, > > > >> > > > >> Thanks for the feedback. Appreciate it! I will update them > accordingly > > > and > > > >> then ask you for double checking. Thanks in advance. > > > >> > > > >> Best regards, > > > >> Jing > > > >> > > > >> On Tue, Oct 17, 2023 at 2:42 PM Yun Tang <myas...@live.com> wrote: > > > >> > > > >>> Hi Jing, > > > >>> > > > >>> Thanks for the update. I checked the new pre-built binary release, > and > > > it > > > >>> works fine now. However, I then checked the pre-built jar packages > and > > > >>> found they are also built with JDK17, e.g., flink-runtime.jar [1]. > > > >>> > > > >>> I think we also need to update all artifacts to be deployed. > > > >>> > > > >>> > > > >>> [1] > > > >>> > > > > https://repository.apache.org/content/repositories/orgapacheflink-1658/org/apache/flink/flink-runtime/1.18.0/flink-runtime-1.18.0.jar > > > >>> > > > >>> Best, > > > >>> Yun Tang > > > >>> > > > >>> > > > >>> ________________________________ > > > >>> From: Matthias Pohl <matthias.p...@aiven.io> > > > >>> Sent: Tuesday, October 17, 2023 20:38 > > > >>> To: dev@flink.apache.org <dev@flink.apache.org> > > > >>> Cc: Yun Tang <myas...@live.com>; sergey.nuyan...@aiven.io < > > > >>> sergey.nuyan...@aiven.io> > > > >>> Subject: Re: [VOTE] Release 1.18.0, release candidate #2 > > > >>> > > > >>> Great catch, Yun Tang. I created FLINK-33291 [1] to cover the > issue of > > > >>> enforcing the JDK (and Maven) version in the release profile. > > > >>> > > > >>> [1] https://issues.apache.org/jira/browse/FLINK-33291 > > > >>> > > > >>> On Tue, Oct 17, 2023 at 1:28 PM Jing Ge <j...@ververica.com.invalid > > > > > >>> wrote: > > > >>> Hi Folks, > > > >>> > > > >>> I have rebuilt Flink with Java 8 and replaced all binary artifacts > > > at[3]. > > > >>> @Yun > > > >>> Tang <myas...@live.com<mailto:myas...@live.com>> Would you please > > > check > > > >>> it again? Thanks! > > > >>> > > > >>> BTW, there was a typo in the voting mail: > > > >>> > > > >>>>> * source code tag "release-1.17.0-rc2" [6] > > > >>> it should be: > > > >>> source code tag "release-1.18.0-rc2" [6] > > > >>> > > > >>> Sorry for the inconvenience caused. > > > >>> > > > >>> Special thanks for @sergey.nuyan...@aiven.io<mailto: > > > >>> sergey.nuyan...@aiven.io> <sergey.nuyan...@aiven.io<mailto: > > > >>> sergey.nuyan...@aiven.io>> who > > > >>> helps double check the new binary files and found the typo. > > > >>> > > > >>> Best regards, > > > >>> Jing > > > >>> > > > >>> [3] https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc2 > > > >>> < > > > >>> > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc2/flink-1.18.0-bin-scala_2.12.tgz > > > >>>> > > > >>> > > > >>> [6] > https://github.com/apache/flink/releases/tag/release-1.18.0-rc2 > > > >>> > > > >>> On Tue, Oct 17, 2023 at 12:27 PM Jing Ge <j...@ververica.com > <mailto: > > > >>> j...@ververica.com>> wrote: > > > >>> > > > >>>> Thanks Chesnay for the hint! Appreciate it! > > > >>>> > > > >>>> > > > >>> Best regards, > > > >>>> Jing > > > >>>> > > > >>>> On Tue, Oct 17, 2023 at 11:21 AM Chesnay Schepler < > ches...@apache.org > > > >>> <mailto:ches...@apache.org>> > > > >>>> wrote: > > > >>>> > > > >>>>> IIRC releases MUST be built with JDK 8. > > > >>>>> > > > >>>>> @Yun Tang how did you discover this? > > > >>>>> > > > >>>>> There is supposed to be a check to enforce this, but weirdly > enough > > > it > > > >>>>> isn't rejecting my JDK 11 installation :/ > > > >>>>> Ah, we didn't set up the enforcer plugin correctly; while we do > set a > > > >>>>> required JDK version by default this is interpreted as ">=", so > > > >>> anything > > > >>>>> above or equal 8 is currently accepted... > > > >>>>> > > > >>>>> On 17/10/2023 07:55, Yun Tang wrote: > > > >>>>>> Hi Jing, > > > >>>>>> > > > >>>>>> I found the pre-built Flink binary release is built with > JDK17[1]. > > > >>>>> Since the default target version is still 1.8 [2] and we did not > > > >>> mention > > > >>>>> that building with java17 is supported [3], do we really need to > make > > > >>> the > > > >>>>> default binary release built with JDK17? > > > >>>>>> > > > >>>>>> > > > >>>>>> [1] > > > >>>>> > > > >>> > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc2/flink-1.18.0-bin-scala_2.12.tgz > > > >>>>>> [2] > > > >>>>> > > > >>> > > > > https://github.com/apache/flink/blob/f978a77e2b9ade1e89dfb681d4b99fc13c72d2ed/pom.xml#L128 > > > >>>>>> [3] > > > >>>>> > > > >>> > > > > https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/flinkdev/building/#build-flink > > > >>>>>> > > > >>>>>> Best, > > > >>>>>> Yun Tang > > > >>>>>> ________________________________ > > > >>>>>> From: Lijie Wang <wangdachui9...@gmail.com<mailto: > > > >>> wangdachui9...@gmail.com>> > > > >>>>>> Sent: Tuesday, October 17, 2023 12:42 > > > >>>>>> To: dev@flink.apache.org<mailto:dev@flink.apache.org> < > > > >>> dev@flink.apache.org<mailto:dev@flink.apache.org>> > > > >>>>>> Subject: Re: [VOTE] Release 1.18.0, release candidate #2 > > > >>>>>> > > > >>>>>> +1 (non-binding) > > > >>>>>> > > > >>>>>> - Verified the signature and checksum > > > >>>>>> - Built from the source code > > > >>>>>> - Ran an example job on yarn cluster > > > >>>>>> - Checked the website PR > > > >>>>>> > > > >>>>>> Best, > > > >>>>>> Lijie > > > >>>>>> > > > >>>>>> Jing Ge <j...@ververica.com.invalid> 于2023年10月16日周一 18:43写道： > > > >>>>>> > > > >>>>>>> Hi everyone, > > > >>>>>>> > > > >>>>>>> Please review and vote on the release candidate #2 for the > version > > > >>>>>>> 1.18.0, as follows: > > > >>>>>>> [ ] +1, Approve the release > > > >>>>>>> [ ] -1, Do not approve the release (please provide specific > > > >>> comments) > > > >>>>>>> > > > >>>>>>> The complete staging area is available for your review, which > > > >>> includes: > > > >>>>>>> > > > >>>>>>> * JIRA release notes [1], and the pull request adding release > note > > > >>> for > > > >>>>>>> users [2] > > > >>>>>>> * the official Apache source release and binary convenience > > > releases > > > >>>>> to be > > > >>>>>>> deployed to dist.apache.org<http://dist.apache.org> [3], > which are > > > >>> signed with the key with > > > >>>>>>> fingerprint 96AE0E32CBE6E0753CE6 [4], > > > >>>>>>> * all artifacts to be deployed to the Maven Central Repository > [5], > > > >>>>>>> * source code tag "release-1.17.0-rc2" [6], > > > >>>>>>> * website pull request listing the new release and adding > > > >>> announcement > > > >>>>> blog > > > >>>>>>> post [7]. > > > >>>>>>> > > > >>>>>>> The vote will be open for at least 72 hours. It is adopted by > > > >>> majority > > > >>>>>>> approval, with at least 3 PMC affirmative votes. > > > >>>>>>> > > > >>>>>>> Best regards, > > > >>>>>>> Konstantin, Qingsheng, Sergey, and Jing > > > >>>>>>> > > > >>>>>>> [1] > > > >>>>>>> > > > >>>>>>> > > > >>>>> > > > >>> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352885 > > > >>>>>>> [2] https://github.com/apache/flink/pull/23527 > > > >>>>>>> [3] > https://dist.apache.org/repos/dist/dev/flink/flink-1.18.0-rc2/ > > > >>>>>>> [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >>>>>>> [5] > > > >>>>> > > > https://repository.apache.org/content/repositories/orgapacheflink-1658 > > > >>>>>>> [6] > > > https://github.com/apache/flink/releases/tag/release-1.18.0-rc2 > > > >>>>>>> [7] https://github.com/apache/flink-web/pull/680 > > > >>>>>>> > > > >>>>> > > > >>>>> > > > >>> > > > >> > > > > > > >
