Hi Wencong, Thanks for the clarification. I got your point. It makes sense.
Wrt IOReadableWritable, the suggestion was to check all classes that implemented it, e.g. BlockInfo, Value, Configuration, etc. Not limited to the Path. Best regards, Jing On Fri, Jul 21, 2023 at 4:31 PM Wencong Liu <liuwencle...@163.com> wrote: > Hello Jing, > > > Thanks for your reply. The URI field should be final and the > Path will be immutable.The static method deserializeFromDataInputView > will create a new Path object instead of replacing the URI field > in a existed Path Object. > > > For the crossing multiple modules issue, I've explained it in the reply > to Matthias. > > > Best regards, > > > Wencong Liu > > > > > > > > > > > > > > > > > > > > At 2023-07-21 18:05:26, "Jing Ge" <j...@ververica.com.INVALID> wrote: > >Hi Wencong, > > > >Just out of curiosity, will the newly introduced > >deserializeFromDataInputView() method make the Path mutable again? > > > >What Matthias suggested makes sense, although the extension might make > this > >FLIP cross multiple modules. > > > >Best regards, > >Jing > > > >On Fri, Jul 21, 2023 at 10:23 AM Matthias Pohl > ><matthias.p...@aiven.io.invalid> wrote: > > > >> There's a kind-of-related issue FLINK-4758 [1] that proposes removing > the > >> IOReadableWritable interface from more classes. It was briefly > mentioned in > >> the must-have work items discussion [2]. > >> > >> I'm not too sure about the usage of IOReadableWritable: ...whether it > would > >> go away with the removal of the DataSet API in general (the Jira issue > has > >> DataSet as a component), anyway. > >> > >> Otherwise, might it make sense to extend the scope of this FLIP? > >> > >> [1] https://issues.apache.org/jira/browse/FLINK-4758 > >> [2] https://lists.apache.org/thread/gf0h4gh3xfsj78cpdsxsnj70nhzcmv9r > >> > >> On Fri, Jul 21, 2023 at 6:04 AM Xintong Song <tonysong...@gmail.com> > >> wrote: > >> > >> > +1 > >> > > >> > Best, > >> > > >> > Xintong > >> > > >> > > >> > > >> > On Fri, Jul 21, 2023 at 10:54 AM Wencong Liu <liuwencle...@163.com> > >> wrote: > >> > > >> > > Hi devs, > >> > > > >> > > I would like to start a discussion on FLIP-347: Remove > >> IOReadableWritable > >> > > serialization in Path [1]. > >> > > > >> > > > >> > > The Path class is currently mutable to support IOReadableWritable > >> > > serialization. However, many parts > >> > > of the code assume that the Path is immutable. By making the Path > class > >> > > immutable, we can ensure > >> > > that paths are stored correctly without the possibility of mutation > and > >> > > eliminate the occurrence of subtle errors. > >> > > As such I propose to modify the Path class to no longer implement > the > >> > > IOReadableWritable interface. > >> > > Looking forward to your feedback. > >> > > [1] > >> > > > >> > > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-347%3A+Remove+IOReadableWritable+serialization+in+Path > >> > > Best regards, > >> > > > >> > > > >> > > Wencong Liu > >> > > >> >
