+1 and thanks for Qingsheng's driving. BTW, shall we consider to create a ticket to ensure backward compatibility of the metric names?
Best, Yun Tang ________________________________ From: Jing Ge <j...@ververica.com> Sent: Friday, October 14, 2022 16:55 To: dev@flink.apache.org <dev@flink.apache.org> Cc: Chesnay Schepler <ches...@apache.org> Subject: Re: [VOTE] Reverting sink metric name changes made in 1.15 +1 The voting title might cause confusion. Technically to say, it is a further modification on top of the current status rather than a reverting after considering the backward compatibility. Best regards, Jing On Fri, Oct 14, 2022 at 10:41 AM Qingsheng Ren <re...@apache.org> wrote: > Thanks for the reply Chesnay! > > I made a POC [1] just now, and I created a draft PR [2] so that it's easier > for everyone to leave comments on it. > > [1] https://github.com/PatrickRen/flink/tree/FLINK-29567-POC > [2] https://github.com/apache/flink/pull/21065 > > Best, > Qingsheng > > > On Fri, Oct 14, 2022 at 1:56 AM Chesnay Schepler <ches...@apache.org> > wrote: > > > Do we have a PoC that achieves this without re-introducing the bug where > > the numRecordsOut was simply wrong because it counted both records > > written to the external system and the downstream committer? > > It's gonna be quite the dirty hack I assume. > > > > On 13/10/2022 19:24, Qingsheng Ren wrote: > > > Hi devs, > > > > > > I'd like to start a vote about reverting sink metric name changes made > in > > > 1.15 considering compatibility issues. These metrics include: > > > > > > - numRecordsSend -> numRecordsOut > > > - numRecordsSendPerSecond -> numRecordsOutPerSecond > > > - numBytesSend -> numBytesOut > > > - numBytesSendPerSecond -> numBytesOutPerSecond > > > - numRecordsSendError -> numRecordsOutError > > > > > > which reflect the output of the sink to the external system. "send" > > metric > > > series will be kept with the same value as "out" metric series. This > > change > > > will be applied to 1.15 and 1.16. More details could be found in the > > > discussion thread [1]. > > > > > > The vote will open for at least 72 hours. > > > > > > Looking forward to your feedback! > > > > > > [1] https://lists.apache.org/thread/vxhty3q97s7pw2zn0jhkyd6sxwwodzbv > > > > > > Best, > > > Qingsheng > > > > > > > >
