+1 from me (non-binding). The documents about these Kafka sink metrics( Flink metrics <https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/ops/metrics//#scope> and Kafka sink monitoring <https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/connectors/datastream/kafka//#monitoring-1>) do not contain the usage of the metrics like numRecordsSend by now. Only Kinesis Sink contains these metrics. If the document about the metrics could be found in other places, please correct me. ;)
Best, Hang Chesnay Schepler <ches...@apache.org> 于2022年10月14日周五 01:56写道： > Do we have a PoC that achieves this without re-introducing the bug where > the numRecordsOut was simply wrong because it counted both records > written to the external system and the downstream committer? > It's gonna be quite the dirty hack I assume. > > On 13/10/2022 19:24, Qingsheng Ren wrote: > > Hi devs, > > > > I'd like to start a vote about reverting sink metric name changes made in > > 1.15 considering compatibility issues. These metrics include: > > > > - numRecordsSend -> numRecordsOut > > - numRecordsSendPerSecond -> numRecordsOutPerSecond > > - numBytesSend -> numBytesOut > > - numBytesSendPerSecond -> numBytesOutPerSecond > > - numRecordsSendError -> numRecordsOutError > > > > which reflect the output of the sink to the external system. "send" > metric > > series will be kept with the same value as "out" metric series. This > change > > will be applied to 1.15 and 1.16. More details could be found in the > > discussion thread [1]. > > > > The vote will open for at least 72 hours. > > > > Looking forward to your feedback! > > > > [1] https://lists.apache.org/thread/vxhty3q97s7pw2zn0jhkyd6sxwwodzbv > > > > Best, > > Qingsheng > > > >
