+1(non-binding) Thanks a lot for the great work. Successfully verified the following: - Checksums and gpg signatures of the tar files. - No binaries in source release - Build from source, build image from source without errors - Helm Repo works, Helm install works - Run HA/python example in application mode - Check licenses in source code
Best, Biao Geng Maximilian Michels <m...@apache.org> 于2022年10月6日周四 20:16写道： > Turns out the issue with the Helm installation was that I was using > cert-manager 1.9.1 instead of the recommended version 1.8.2. The operator > now deploys cleanly in my local environment. > > On Thu, Oct 6, 2022 at 12:34 PM Maximilian Michels <m...@apache.org> wrote: > > > +1 (binding) because the source release looks good. > > > > I've verified the following: > > > > 1. Downloaded, compiled, and verified the signature of the source release > > staged at > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.2.0-rc2/ > > 2. Verified licenses (Not a blocker: the LICENSE file does not contain a > > link to the bundled licenses directory, this should be fixed in future > > releases) > > 3. Verified the Helm Chart > > > > The Helm chart installation resulted in the following pod events: > > > > Events: > > Type Reason Age From Message > > ---- ------ ---- ---- ------- > > Normal Scheduled 5m42s default-scheduler > > Successfully assigned default/flink-kubernetes-operator-54fcd9df98-645rf > > to docker-desktop > > Warning FailedMount 3m39s kubelet Unable > to > > attach or mount volumes: unmounted volumes=[keystore], unattached > > volumes=[kube-api-access-pdnzw keystore flink-operator-config-volume]: > > timed out waiting for the condition > > Warning FailedMount 92s (x10 over 5m42s) kubelet > > MountVolume.SetUp failed for volume "keystore" : secret > > "webhook-server-cert" not found > > Warning FailedMount 84s kubelet Unable > to > > attach or mount volumes: unmounted volumes=[keystore], unattached > > volumes=[flink-operator-config-volume kube-api-access-pdnzw keystore]: > > timed out waiting for the condition > > > > Do we need to list any additional steps in the docs? > > > https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/try-flink-kubernetes-operator/quick-start/ > > > > -Max > > > > On Wed, Oct 5, 2022 at 2:16 PM Őrhidi Mátyás <matyas.orh...@gmail.com> > > wrote: > > > >> +1 (non-binding) > >> > >> - Verified source distributions (except the licenses and maven > artifacts) > >> - Verified Helm chart and Docker image > >> - Verified basic examples > >> > >> Everything seems okay to me. > >> > >> Cheers, > >> Matyas > >> > >> On Tue, Oct 4, 2022 at 10:27 PM Gyula Fóra <gyula.f...@gmail.com> > wrote: > >> > >> > +1 (binding) > >> > > >> > - Verified Helm repo works as expected, points to correct image tag, > >> build, > >> > version > >> > - Verified examples + checked operator logs everything looks as > expected > >> > - Verified hashes, signatures and source release contains no binaries > >> > - Ran built-in tests, built jars + docker image from source > successfully > >> > > >> > Cheers, > >> > Gyula > >> > > >> > On Sat, Oct 1, 2022 at 2:27 AM Jim Busche <jbus...@us.ibm.com> wrote: > >> > > >> > > +1 (not-binding) > >> > > > >> > > Thank you Gyula, > >> > > > >> > > > >> > > Helm install from flink-kubernetes-operator-1.2.0-helm.tgz looks > good, > >> > > logs look normal > >> > > > >> > > podman Dockerfile build from source looks good. > >> > > > >> > > twistlock security scans of the proposed image look good: > >> > > ghcr.io/apache/flink-kubernetes-operator:95128bf > >> > > > >> > > UI and basic sample look good. > >> > > > >> > > Checksums looked good. > >> > > > >> > > Tested on OpenShift 4.10.25. Will try additional versions (4.8 and > >> 4.11) > >> > > if I get an opportunity, but I don't expect issues. > >> > > > >> > > > >> > > > >> > > Thank you, > >> > > > >> > > James Busche > >> > > > >> > > >> > > >
