+1 (non-binding) - Verified source distributions (except the licenses and maven artifacts) - Verified Helm chart and Docker image - Verified basic examples
Everything seems okay to me. Cheers, Matyas On Tue, Oct 4, 2022 at 10:27 PM Gyula Fóra <gyula.f...@gmail.com> wrote: > +1 (binding) > > - Verified Helm repo works as expected, points to correct image tag, build, > version > - Verified examples + checked operator logs everything looks as expected > - Verified hashes, signatures and source release contains no binaries > - Ran built-in tests, built jars + docker image from source successfully > > Cheers, > Gyula > > On Sat, Oct 1, 2022 at 2:27 AM Jim Busche <jbus...@us.ibm.com> wrote: > > > +1 (not-binding) > > > > Thank you Gyula, > > > > > > Helm install from flink-kubernetes-operator-1.2.0-helm.tgz looks good, > > logs look normal > > > > podman Dockerfile build from source looks good. > > > > twistlock security scans of the proposed image look good: > > ghcr.io/apache/flink-kubernetes-operator:95128bf > > > > UI and basic sample look good. > > > > Checksums looked good. > > > > Tested on OpenShift 4.10.25. Will try additional versions (4.8 and 4.11) > > if I get an opportunity, but I don't expect issues. > > > > > > > > Thank you, > > > > James Busche > > >
