+1 from my side, thanks for driving this improvement. Best, Leonard
> 2022年3月2日 下午7:13，Jiangang Liu <liujiangangp...@gmail.com> 写道： > > +1 for the feature. Good style management can help the developer a lot. > > Marios Trivyzas <mat...@gmail.com> 于2022年3月2日周三 18:19写道： > >> +1 from me as well, Having a unified auto-formatter for scala would be >> great. >> Currently we don't have consistency in our code base, and this makes it >> more difficult >> to read and work on the scala code. >> >> Best, >> Marios >> >> On Wed, Mar 2, 2022 at 11:41 AM wenlong.lwl <wenlong88....@gmail.com> >> wrote: >> >>> +1, currently the scalastyle does not work well actually, there are a lot >>> of style differences in different files. It would be great if the code >> can >>> be auto formatted. >>> >>> Best, >>> Wenlong >>> >>> On Wed, 2 Mar 2022 at 16:34, Jingsong Li <jingsongl...@gmail.com> wrote: >>> >>>> +1. >>>> >>>> Thanks for driving. >>>> >>>> I wrote some scala code, the style of our flink's scala is messy. We >>>> can do better. >>>> >>>> Best, >>>> Jingsong >>>> >>>> On Wed, Mar 2, 2022 at 4:19 PM Yun Tang <myas...@live.com> wrote: >>>>> >>>>> +1 >>>>> >>>>> I also noticed that the project of scalafmt [1] is much more active >>> than >>>> scalatyle [2], which has no release in the past 4 years. >>>>> >>>>> >>>>> [1] https://github.com/scalameta/scalafmt/releases >>>>> [2] https://github.com/scalastyle/scalastyle/tags >>>>> >>>>> Best >>>>> Yun Tang >>>>> >>>>> ________________________________ >>>>> From: Konstantin Knauf <kna...@apache.org> >>>>> Sent: Wednesday, March 2, 2022 15:01 >>>>> To: dev <dev@flink.apache.org> >>>>> Subject: Re: [DISCUSS] Enable scala formatting check >>>>> >>>>> +1 I've never written any Scala in Flink, but this makes a lot of >> sense >>>> to >>>>> me. Converging on a smaller set of tools and simplifying the build is >>>>> always a good idea and the Community already concluded before that >>>> spotless >>>>> is generally a good approach. >>>>> >>>>> On Tue, Mar 1, 2022 at 5:52 PM Francesco Guardiani < >>>> france...@ververica.com> >>>>> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> I want to propose to enable the spotless scalafmt integration and >>>> remove >>>>>> the scalastyle plugin. >>>>>> >>>>>> From an initial analysis, scalafmt can do everything scalastyle can >>>> do, and >>>>>> the integration with spotless looks easy to enable: >>>>>> https://github.com/diffplug/spotless/tree/main/plugin-maven#scala. >>> The >>>>>> scalafmt conf file gets picked up automatically from every IDE, and >>> it >>>> can >>>>>> be heavily tuned. >>>>>> >>>>>> This way we can unify the formatting and integrate with our CI >>> without >>>> any >>>>>> additional configurations. And we won't need scalastyle anymore, as >>>>>> scalafmt will take care of the checks: >>>>>> >>>>>> * mvn spotless:check will check both java and scala >>>>>> * mvn spotless:apply will format both java and scala >>>>>> >>>>>> WDYT? >>>>>> >>>>>> FG >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Francesco Guardiani | Software Engineer >>>>>> >>>>>> france...@ververica.com >>>>>> >>>>>> >>>>>> <https://www.ververica.com/> >>>>>> >>>>>> Follow us @VervericaData >>>>>> >>>>>> -- >>>>>> >>>>>> Join Flink Forward <https://flink-forward.org/> - The Apache Flink >>>>>> Conference >>>>>> >>>>>> Stream Processing | Event Driven | Real Time >>>>>> >>>>>> -- >>>>>> >>>>>> Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany >>>>>> >>>>>> -- >>>>>> >>>>>> Ververica GmbH >>>>>> >>>>>> Registered at Amtsgericht Charlottenburg: HRB 158244 B >>>>>> >>>>>> Managing Directors: Karl Anton Wehner, Holger Temme, Yip Park Tung >>>> Jason, >>>>>> Jinwei (Kevin) Zhang >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Konstantin Knauf >>>>> >>>>> https://twitter.com/snntrable >>>>> >>>>> https://github.com/knaufk >>>> >>> >> >> >> -- >> Marios >>
