+1 I've never written any Scala in Flink, but this makes a lot of sense to me. Converging on a smaller set of tools and simplifying the build is always a good idea and the Community already concluded before that spotless is generally a good approach.
On Tue, Mar 1, 2022 at 5:52 PM Francesco Guardiani <france...@ververica.com> wrote: > Hi all, > > I want to propose to enable the spotless scalafmt integration and remove > the scalastyle plugin. > > From an initial analysis, scalafmt can do everything scalastyle can do, and > the integration with spotless looks easy to enable: > https://github.com/diffplug/spotless/tree/main/plugin-maven#scala. The > scalafmt conf file gets picked up automatically from every IDE, and it can > be heavily tuned. > > This way we can unify the formatting and integrate with our CI without any > additional configurations. And we won't need scalastyle anymore, as > scalafmt will take care of the checks: > > * mvn spotless:check will check both java and scala > * mvn spotless:apply will format both java and scala > > WDYT? > > FG > > > > -- > > Francesco Guardiani | Software Engineer > > france...@ververica.com > > > <https://www.ververica.com/> > > Follow us @VervericaData > > -- > > Join Flink Forward <https://flink-forward.org/> - The Apache Flink > Conference > > Stream Processing | Event Driven | Real Time > > -- > > Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany > > -- > > Ververica GmbH > > Registered at Amtsgericht Charlottenburg: HRB 158244 B > > Managing Directors: Karl Anton Wehner, Holger Temme, Yip Park Tung Jason, > Jinwei (Kevin) Zhang > -- Konstantin Knauf https://twitter.com/snntrable https://github.com/knaufk
