Hey Yang,
thanks! See inline answers.
On Fri, Apr 3, 2020 at 5:11 AM Yang Wang <danrtsey...@gmail.com> wrote:
> Hi Ufuk,
>
> Thanks for make the conclusion and directly point out what need to be done
> in
> FLIP-111. I agree with you that we should narrow down the scope and focus
> the
> most important and basic part about docker image unification.
>
> (1) Extend the entrypoint script in apache/flink-docker to start the job
>> cluster entry point
>
> I want to add a small requirement for the entry point script. Currently,
> for the native
> K8s integration, we are using the apache/flink-docker image, but with
> different entry
> point("kubernetes-entry.sh"). Generate the java cmd in KubernetesUtils and
> run it
> in the entry point. I really hope it could merge to apache/flink-docker
> "docker-entrypoint.sh".
>
The script [1] only adds the FLINK_CLASSPATH env var which seems generally
reasonable to me. But since principled classpath and entrypoint
configuration is somewhat related to the follow-up improvement proposals, I
could also see this being done after FLIP-111.
> (2) Extend the example log4j-console configuration
>> => support log retrieval from the Flink UI out of the box
>
> If you mean to update the "flink-dist/conf/log4j-console.properties" to
> support console and
> local log files. I will say "+1". But we need to find a proper way to make
> stdout/stderr output
> both available for console and log files. Maybe till's proposal could help
> to solve this.
> "`program &2>1 | tee flink-user-taskexecutor.out`"
>
I think we can simply add a rolling file appender with a limit on the log
size.
– Ufuk
[1]
https://github.com/apache/flink/blob/master/flink-dist/src/main/flink-bin/kubernetes-bin/kubernetes-entry.sh
