The BucketingSink is still somewhat widely used, I think in part because of
shortcomings in the StreamingFileSink.

I would hope that in tandem with removing the bucketing sink we could also
address some of these issues. I'm thinking in particular of issues that are
waiting on FLIP-46 [1].

Removing the bucketing sink will go down better, in my opinion, if it's
coupled with progress on some of the open StreamingFileSink tickets.

Best,
David

[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-46%3A+Graceful+Shutdown+Handling+by+UDFs


On Thu, Mar 12, 2020 at 4:27 PM Zhijiang <wangzhijiang...@aliyun.com.invalid>
wrote:

> Thanks for driving this discussion, Robert!
>
> This e2e test really fails frequently.  +1 to drop bucketing sink, it is
> not worth paying more efforts since deprecated.
>
> Best,
> Zhijiang
>
>
> ------------------------------------------------------------------
> From:Jeff Zhang <zjf...@gmail.com>
> Send Time:2020 Mar. 12 (Thu.) 23:17
> To:dev <dev@flink.apache.org>
> Subject:Re: [DISCUSS] Drop Bucketing Sink
>
> +1, dropping deprecated api is always necessary for a sustainable project.
>
> Kostas Kloudas <kklou...@gmail.com> 于2020年3月12日周四 下午11:06写道:
>
> > Hi Robert,
> >
> > +1 for dropping the BucketingSink.
> > In any case, it has not been maintained for quite some time.
> >
> > Cheers,
> > Kostas
> >
> > On Thu, Mar 12, 2020 at 3:41 PM Robert Metzger <rmetz...@apache.org>
> > wrote:
> > >
> > > Hi all,
> > >
> > > I'm currently investigating a failing end to end test for the bucketing
> > > sink [1].
> > > The bucketing sink has been deprecated in the 1.9 release [2], because
> we
> > > have the new StreamingFileSink [3] for quite a while.
> > > Before putting any effort into fixing the end to end test for the
> sink, I
> > > wanted to propose dropping the bucketing sink from master for the
> > upcoming
> > > 1.11 release.
> > >
> > > What do you think?
> > >
> > >
> > >
> > > [1] https://issues.apache.org/jira/browse/FLINK-16227
> > > [2] https://issues.apache.org/jira/browse/FLINK-13396
> > > [3] https://issues.apache.org/jira/browse/FLINK-9749
> >
>
>
> --
> Best Regards
>
> Jeff Zhang
>
>

Reply via email to