> * Why are we duplicating the subtask index in the objects that are stored in the attempts-time-info array? I thought that all objects in the same array share the same subtask index. yes, I agree with you that subtask could be removed in the `attempts-time-info`
> * Are we confident that the attempts-time-info array does not grow too large during the lifetime of a job? Should the size of the array be limited? no, I think it is a similar situation to taskmanager/jobmanager log API, all data response from the rest API could grow too large, but add query params in the RestAPI would also bring pressure to the server. > * Have we considered placing the historic attempts in the same array as the current attempts, i.e., flatten the arrays? One could toggle the historic attempts on and off with a query parameter. it is a good idea considering the previous situation, this would be useful not blocking the previous feature even if the history becomes too large, we will implement this and update the POC later. > * I think 'attempt-history' would be a better name instead of 'attempts-time-info'. Yes, I agree with you, we will update it later. Gary Yao <g...@apache.org> 于2020年3月2日周一 下午10:50写道： > Hi Yadong, > > Thanks for driving this FLIP. I have a few questions/remarks: > > * Why are we duplicating the subtask index in the objects that are > stored in the attempts-time-info array? I thought that all objects in the > same array share the same subtask index. > * Are we confident that the attempts-time-info array does not grow too > large during the lifetime of a job? Should the size of the array be > limited? > * Have we considered placing the historic attempts in the same array as > the current attempts, i.e., flatten the arrays? One could toggle the > historic attempts on and off with a query parameter. > * I think 'attempt-history' would be a better name instead of > 'attempts-time-info'. > > Let me know what you think. > > Best, > Gary > > On Thu, Feb 20, 2020 at 10:46 AM Yadong Xie <vthink...@gmail.com> wrote: > > > Hi all > > > > I want to start the vote for FLIP-100, which proposes to add attempt > > information inside subtask and timeline in web UI. > > > > To help everyone better understand the proposal, we spent some efforts on > > making an online POC > > > > Timeline Attempt (click the vertex timeline to see the differences): > > previous web: > > > http://101.132.122.69:8081/#/job/9d651769488466d33e7a607e85203543/timeline > > POC web: > > > > > http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/timeline > > > > Subtask Attempt (click the vertex and switch to subtask tab to see the > > differences): > > previous web: > > > http://101.132.122.69:8081/#/job/9d651769488466d33e7a607e85203543/overview > > POC web: > > > > > http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/overview > > > > > > The vote will last for at least 72 hours, following the consensus voting > > process. > > > > FLIP wiki: > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information > > > > Discussion thread: > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-75-Flink-Web-UI-Improvement-Proposal-td33540.html > > > > Thanks, > > > > Yadong > > >
