Hi everyone A subtask filter and an attempt id filter was added to the attempt timeline page now
check the POC here: http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/timeline FLIP doc was also updated: https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information Till Rohrmann <trohrm...@apache.org> 于2020年2月27日周四 下午9:49写道： > I think your proposal is better because then we don't have to bump the REST > API version. > > Cheers, > Till > > On Thu, Feb 27, 2020 at 8:02 AM Yadong Xie <vthink...@gmail.com> wrote: > > > Hi Till > > > > We keep response a flattened SubtaskTimeInfo and an array of > > SubtaskTimeInfo to keep the restAPI backward compatible, since Flink > users > > may still need the API('/jobs/{jobId}/vertices/{vertexId}/subtasktimes') > to > > get the flattened SubtaskTimeInfo. > > > > If we want to get an array of SubtaskTimeInfo in the API, a new URL needs > > to be created other than reuse the old one. > > > > Both solutions are ok for me. What do you think about it? > > > > Till Rohrmann <trohrm...@apache.org> 于2020年2月26日周三 下午10:53写道： > > > > > Fair enough. If this should become a problem we could introduce it > later > > as > > > well. > > > > > > What about changing the SubtasksTimeInfo response type into an array of > > > SubtaskTimeInfo? At the moment SubtasksTimeInfo contains a > > > flattened SubtaskTimeInfo and and array of SubtaskTimeInfo for the > > previous > > > attempts. > > > > > > Cheers, > > > Till > > > > > > On Wed, Feb 26, 2020 at 1:16 PM Yadong Xie <vthink...@gmail.com> > wrote: > > > > > > > Hi Till > > > > > > > > Thanks for your comments. > > > > > > > > > I have a comment concerning the SubtasksTimesHandler.... > > > > > > > > It would be much easier for the frontend to handle a large amount of > > data > > > > if we have a rest API parameter filter, but in my opinion, the > attempt > > > list > > > > data is not large enough that we have to rely on the rest API > > parameters > > > > paging, we still can handle them all in the frontend. > > > > > > > > Users can filter the attempt list by the > > > status(scheduled/created/deploying > > > > and so on) and other keywords(attempt_id and so on) directly in the > > > > frontend since all data are listed from the rest API. > > > > If we move some of the filter parameters to the rest API path > > parameter, > > > > all the other filter parameters need to be moved too. > > > > > > > > I suggest adding an attempt id filter in the UI to help users filter > > the > > > > desired attempt, and all the filtering process is running inside the > > > > browser side, what do you think about this? > > > > > > > > > > > > > > > > > > > > Till Rohrmann <trohrm...@apache.org> 于2020年2月25日周二 下午11:40写道： > > > > > > > > > Hi Yadong, > > > > > > > > > > thanks for creating this FLIP. I like the idea to make the web-ui > > > > > information richer wrt to subtask attempt information. > > > > > > > > > > I have a comment concerning the SubtasksTimesHandler: Should we > > change > > > > the > > > > > response type SubtasksTimeInfo so that it simply contains an > > > > > array of SubtaskTimeInfo? One could add an attempt range path > > parameter > > > > to > > > > > the SubtasksTimesHandler to be able to control which attempts will > be > > > > > returned. > > > > > > > > > > Cheers, > > > > > Till > > > > > > > > > > On Tue, Feb 25, 2020 at 9:57 AM Benchao Li <libenc...@gmail.com> > > > wrote: > > > > > > > > > > > Hi Yadong, > > > > > > > > > > > > Thanks for the updating. LGTM now. > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Yadong Xie <vthink...@gmail.com> 于2020年2月25日周二 下午4:41写道： > > > > > > > > > > > > > Hi Kurt > > > > > > > > > > > > > > There will be no differences between batch jobs and stream jobs > > in > > > > > > > subtask-attempt level in the UI > > > > > > > The only differences are in the vertex timeline, I have added a > > > > > > screenshot > > > > > > > of the batch job in the FLIP-100 since the batch job will > > disappear > > > > > from > > > > > > > the list after it finished soon. > > > > > > > here is the link: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information > > > > > > > > > > > > > > > > > > > > > Kurt Young <ykt...@gmail.com> 于2020年2月21日周五 上午11:51写道： > > > > > > > > > > > > > > > Hi Yadong, > > > > > > > > > > > > > > > > Thanks for the proposal, it's a useful feature, especially > for > > > > batch > > > > > > > jobs. > > > > > > > > But according > > > > > > > > to the examples you gave, I can't tell whether i got required > > > > > > information > > > > > > > > from that. > > > > > > > > Can you replace the demo job to a more complex batch job and > > then > > > > we > > > > > > can > > > > > > > > see some > > > > > > > > differences of start/stop time of different tasks and > attempts? > > > > > > > > > > > > > > > > Best, > > > > > > > > Kurt > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Feb 20, 2020 at 5:46 PM Yadong Xie < > > vthink...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi all > > > > > > > > > > > > > > > > > > I want to start the vote for FLIP-100, which proposes to > add > > > > > attempt > > > > > > > > > information inside subtask and timeline in web UI. > > > > > > > > > > > > > > > > > > To help everyone better understand the proposal, we spent > > some > > > > > > efforts > > > > > > > on > > > > > > > > > making an online POC > > > > > > > > > > > > > > > > > > Timeline Attempt (click the vertex timeline to see the > > > > > differences): > > > > > > > > > previous web: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://101.132.122.69:8081/#/job/9d651769488466d33e7a607e85203543/timeline > > > > > > > > > POC web: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/timeline > > > > > > > > > > > > > > > > > > Subtask Attempt (click the vertex and switch to subtask tab > > to > > > > see > > > > > > the > > > > > > > > > differences): > > > > > > > > > previous web: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://101.132.122.69:8081/#/job/9d651769488466d33e7a607e85203543/overview > > > > > > > > > POC web: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://101.132.122.69:8081/web/#/job/9d651769488466d33e7a607e85203543/overview > > > > > > > > > > > > > > > > > > > > > > > > > > > The vote will last for at least 72 hours, following the > > > consensus > > > > > > > voting > > > > > > > > > process. > > > > > > > > > > > > > > > > > > FLIP wiki: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-100%3A+Add+Attempt+Information > > > > > > > > > > > > > > > > > > Discussion thread: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-75-Flink-Web-UI-Improvement-Proposal-td33540.html > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > Yadong > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > Benchao Li > > > > > > School of Electronics Engineering and Computer Science, Peking > > > > University > > > > > > Tel:+86-15650713730 > > > > > > Email: libenc...@gmail.com; libenc...@pku.edu.cn > > > > > > > > > > > > > > > > > > > > >
