Thanks for the feedback, Konstantin, Completely agree that exposing the original metrics from the clients of other systems is a good practice and should be encouraged.
Thanks, Jiangjie (Becket) Qin On Fri, Feb 1, 2019 at 4:01 PM Konstantin Knauf <konstan...@da-platform.com> wrote: > Hi Becket, > > I like the idea of providing a standard set of metrics, which sources can > choose to implement/expose. In addition, I think, sources, like the Kafka > or Kinesis Source, should continue to forward the original consumer metrics > under their original names, so that users familiar with Kafka/Kinesis can > relate to them easily. > > Cheers, > > Konstantin > > > > On Fri, Feb 1, 2019 at 3:54 AM Becket Qin <becket....@gmail.com> wrote: > > > Thanks for the connector metric url, Chesnay :) > > > > @Robert, as you can see, the metrics from different connectors are quite > > different. And there are different names for similar metrics, which is a > > little frustrating when users want to do monitoring / alerting. > > > > Thanks, > > > > Jiangjie (Becket) Qin > > > > On Thu, Jan 31, 2019 at 6:41 PM Chesnay Schepler <ches...@apache.org> > > wrote: > > > > > @Robert: > > > > > > > > > https://ci.apache.org/projects/flink/flink-docs-master/monitoring/metrics.html#connectors > > > > > > On 31.01.2019 11:03, Robert Metzger wrote: > > > > Hey Becket, > > > > thanks a lot for your proposal! > > > > > > > > Do you have an overview over the current situation of the metrics in > > the > > > > connectors? > > > > Which connectors expose metrics at all? > > > > Are they different? > > > > > > > > On Thu, Jan 31, 2019 at 8:44 AM Becket Qin <becket....@gmail.com> > > wrote: > > > > > > > >> Hi folks, > > > >> > > > >> I was trying to add some metrics to Kafka connectors and realized > that > > > >> right now Flink does not have a common metric definition for the > > > >> connectors. This complicates the monitoring and operation because > the > > > >> monitoring / alerts need to be set case by case. > > > >> > > > >> To address this issue, I would like to see if is possible to have a > > set > > > of > > > >> standardized common metrics for all sources and sinks. The following > > doc > > > >> describes the proposal. Feedback is very welcome. > > > >> > > > >> > > > >> > > > > > > https://docs.google.com/document/d/1q86bgj_3T6WFbSUoxLDJJXmUcBOUcvWfh2RZvHG-nPU/edit# > > > >> > > > >> Thanks, > > > >> > > > >> Jiangjie (Becket) Qin > > > >> > > > > > > > > > > > -- > -- > > Konstantin Knauf | Solution Architect > > > -- > > Join Flink Forward <https://flink-forward.org/> - The Apache Flink > Conference > > Stream Processing | Event Driven | Real Time > > -- > > Data Artisans GmbH | Stresemannstr. 121A,10963 Berlin, Germany > < > https://maps.google.com/?q=Stresemannstr.+121A,10963+Berlin,+Germany&entry=gmail&source=g > > > data Artisans, Inc. | 1161 Mission Street, San Francisco, CA-94103, USA > < > https://maps.google.com/?q=1161+Mission+Street,+San+Francisco,+CA-94103,+USA&entry=gmail&source=g > > > > -- > Data Artisans GmbH > Registered at Amtsgericht Charlottenburg: HRB 158244 B > Managing Directors: Dr. Kostas Tzoumas, Dr. Stephan Ewen >