Hi, Alexey I will check abandoned PRs to reduce obviously outdated ones and add them to a cleanup list https://issues.apache.org/jira/browse/FLINK-5384
-----Original Message----- From: Alexey Demin [mailto:diomi...@gmail.com] Sent: Monday, January 16, 2017 5:05 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] (Not) tagging reviewers Hi all View from my prospective: in middle of summer - 150 PR in middle of autumn - 180 now 206. This is mix of bugfixes and improvements. I understand that work on new features important, but when small and trivial fixes stay in states of PR more then 2-3 month, then all users think about changing engine on other product. Only way push people to merge this fixes in master it's tags. I don't speak about big changes, only about small and trivial with review less then 5 min. Features important, but if this features work incorrect, then user can select more stability product without any hesitation. Thanks Alexey Diomin 2017-01-16 16:36 GMT+04:00 Ufuk Celebi <u...@apache.org>: > On 16 January 2017 at 12:59:04, Paris Carbone (par...@kth.se) wrote: > > > Though, when someone has started reviewing a PR and shows interest > > it probably makes sense to finish doing so. Wouldn’t tagging be > > acceptable there? > > In those case tagging triggers direct notifications, so that people > > already involved in a conversation get reminded and answer pending > > questions. > > I think that's totally fine Paris since it is more of a reminder in > that case. > > Stephan is referring to PRs that have a last line in the description > like "@XZY for review please". > > – Ufuk > > >
