Thanks for bringing this up Stephan. I completely agree with you. Cheers, Fabian
2017-01-16 12:42 GMT+01:00 Stephan Ewen <se...@apache.org>: > Hi! > > I have seen that recently many pull requests designate reviews by writing > "@personA review please" or so. > > I am personally quite strongly against that, I think it hurts the community > work: > > - The same few people get usually "designated" and will typically get > overloaded and often not do the review. > > - At the same time, this discourages other community members from looking > at the pull request, which is totally undesirable. > > - In general, review participation should be "pull based" (person decides > what they want to work on) not "push based" (random person pushes work to > another person). Push-based just creates the wrong feeling in a community > of volunteers. > > - In many cases the designated reviews are not the ones most > knowledgeable in the code, which is understandable, because how should > contributors know whom to tag? > > > Long story short, why don't we just drop that habit? > > > Greetings, > Stephan >