Sorry for late reply, but +1 too This should still provide tracking of discussion from Github PR and reduce the noise at the same time.
Thanks for working on it, Max. - Henry On Fri, Sep 2, 2016 at 8:42 AM, Till Rohrmann <trohrm...@apache.org> wrote: > +1 > > On Fri, Sep 2, 2016 at 4:20 PM, Fabian Hueske <fhue...@gmail.com> wrote: > > > +1 > > > > Thanks Max! > > > > 2016-09-02 15:20 GMT+02:00 Stephan Ewen <se...@apache.org>: > > > > > Sounds good to me! > > > > > > On Fri, Sep 2, 2016 at 3:08 PM, Maximilian Michels <m...@apache.org> > > wrote: > > > > > > > If there are no objections, I will contact Infra to change the GitHub > > > > JIRA notifications as follows: > > > > > > > > Jira comments section > > > > - initial PR description > > > > - comments of the main GitHub thread > > > > > > > > Jira Work Log > > > > - all diff comments > > > > > > > > > > > > On Mon, Aug 29, 2016 at 6:58 PM, Maximilian Michels <m...@apache.org> > > > > wrote: > > > > >> Will work log updates still lead to notifications on the mailing > > list? > > > > > > > > > > I don't know but it is most likely configurable. I would prefer if > we > > > > > didn't get notifications for work log items because these would > again > > > > > be duplicates of the GitHub notifications. > > > > > > > > > > On Mon, Aug 29, 2016 at 5:39 PM, Neelesh Salian < > > nsal...@cloudera.com> > > > > wrote: > > > > >> Thanks Max for coordinating the effort. > > > > >> +1 as well. > > > > >> > > > > >> > > > > >> On Mon, Aug 29, 2016 at 6:57 AM, Robert Metzger < > > rmetz...@apache.org> > > > > wrote: > > > > >> > > > > >>> +1 > > > > >>> > > > > >>> I didn't know that we can put the comments into the work log. > > > > >>> Will work log updates still lead to notifications on the mailing > > > list? > > > > >>> > > > > >>> On Mon, Aug 29, 2016 at 11:52 AM, Maximilian Michels < > > m...@apache.org > > > > > > > > >>> wrote: > > > > >>> > > > > >>> > From what I understand so far, the message mirroring can be > > > adjusted > > > > >>> > in the follow parts: > > > > >>> > > > > > >>> > 1) GitHub PR description > > > > >>> > 2) GitHub Diff comments > > > > >>> > 3) GitHub Main thread comments > > > > >>> > > > > > >>> > We can choose to put these as > > > > >>> > > > > > >>> > 1) The full GitHub comment > > > > >>> > 2) Only supply a link to the GitHub comment > > > > >>> > > > > > >>> > Next, we can store all posts to JIRA > > > > >>> > > > > > >>> > 1) In the JIRA main comments > > > > >>> > 2) In the Work Log > > > > >>> > > > > > >>> > > > > > >>> > I think it would be a nice setup to have the GitHub PR > > description > > > > and > > > > >>> > comments directly in the JIRA comments. Diff comments should go > > in > > > > the > > > > >>> > Work Log. > > > > >>> > > > > > >>> > On Fri, Aug 19, 2016 at 2:56 PM, Maximilian Michels < > > > m...@apache.org> > > > > >>> > wrote: > > > > >>> > > Sure, I've filed a JIRA: https://issues.apache.org/ > > > > >>> > jira/browse/INFRA-12456 > > > > >>> > > > > > > >>> > > On Thu, Aug 18, 2016 at 10:57 AM, Stephan Ewen < > > se...@apache.org > > > > > > > > >>> wrote: > > > > >>> > >> @max - can you contact infra about that? > > > > >>> > >> > > > > >>> > >> On Thu, Aug 18, 2016 at 10:25 AM, Maximilian Michels < > > > > m...@apache.org> > > > > >>> > wrote: > > > > >>> > >> > > > > >>> > >>> Actually that is a good suggestion. I know from other > Apache > > > > projects > > > > >>> > >>> that they only mirror the initial description of the pull > > > > request but > > > > >>> > >>> not the discussion. I agree with you that it's very hard to > > > have > > > > >>> > >>> meaningful discussion in JIRA if it is overlapped with > GitHub > > > > >>> > >>> comments. > > > > >>> > >>> > > > > >>> > >>> Cheers, > > > > >>> > >>> Max > > > > >>> > >>> > > > > >>> > >>> On Wed, Aug 17, 2016 at 10:52 PM, Neelesh Salian < > > > > >>> nsal...@cloudera.com > > > > >>> > > > > > > >>> > >>> wrote: > > > > >>> > >>> > Hello, > > > > >>> > >>> > > > > > >>> > >>> > I have noticed there is a high verbosity coming from the > PR > > > > into > > > > >>> the > > > > >>> > JIRA > > > > >>> > >>> > which makes it hard to focus on the message or the > content > > of > > > > the > > > > >>> PR > > > > >>> > >>> > through the JIRA itself. > > > > >>> > >>> > Has there been a discussion over minimizing the details > > > > displayed > > > > >>> > back on > > > > >>> > >>> > the PR's JIRA? > > > > >>> > >>> > > > > > >>> > >>> > Maybe just add the PR link and the description of the > > changes > > > > >>> rather > > > > >>> > than > > > > >>> > >>> > the entire template? > > > > >>> > >>> > > > > > >>> > >>> > Any thoughts? > > > > >>> > >>> > > > > > >>> > >>> > Regards, > > > > >>> > >>> > > > > > >>> > >>> > -- > > > > >>> > >>> > Neelesh Srinivas Salian > > > > >>> > >>> > > > > >>> > > > > > >>> > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> Neelesh Srinivas Salian > > > > >> Customer Operations Engineer > > > > > > > > > >