+1 (binding) - build against Scala 2.11 - start-local (CLI, Webclient, Dashboard, log files, examples with build-in and external data) - start-cluster, local (2 JVMs, CLI + Webclient, Dashboard, log files, examples with build-in and external data)
2016-02-07 20:21 GMT+01:00 Ufuk Celebi <u...@apache.org>: > +1 (binding) > > - Checked checksums > - No binaries in source release > - Ran mvn clean verify > - Build for Hadoop 2.7 > - Checked version in POM files > - Ran the start up scripts and examined log/out files > - Ran tests on multi-node cluster > - Tested with HDFS > - Tested command line client > - Ran examples on YARN cluster (Hadoop 2.7) > - Tested recovery with StreamingStateMachine (YARN/Standalone) > > – Ufuk > > > On 06 Feb 2016, at 17:34, Stephan Ewen <se...@apache.org> wrote: > > > > +1 (binding) > > > > - Built the code (Linux x64, Scala 2.10, Hadoop 2.3.0) > > - Ran all tests > > - Checked that there are no cross-version dependencies > > - Checked that LICENSE and NOTICE are up to date > > - Check planVisualizer util > > - ran examples from command line > > - tested web frontend on Firefox and Chrome > > - ran program on multiple taskmanagers, killed one during execution, > > recovery worked properly > > > > > > Minor issue: The log4j.properties in "flink-runtime" causes a lot of test > > exceptions to be printed, which looks confusing when running the tests. > > > > > > > > On Fri, Feb 5, 2016 at 2:17 PM, Fabian Hueske <fhue...@gmail.com> wrote: > > > >> Fair enough > >> > >> 2016-02-05 14:09 GMT+01:00 Stephan Ewen <se...@apache.org>: > >> > >>> I would also be in favor of continuing the RC, if we find nothing more > >>> problematic > >>> > >>> On Fri, Feb 5, 2016 at 1:51 PM, Maximilian Michels <m...@apache.org> > >> wrote: > >>> > >>>> Thanks for the RC. The documentation version is a really minor issue > >>>> which most people won't even notice because they use the online > >>>> documentation. I wouldn't create a new RC just for fixing that. > >>>> > >>>> On Fri, Feb 5, 2016 at 12:45 PM, Ufuk Celebi <u...@apache.org> wrote: > >>>>> > >>>>>> On 05 Feb 2016, at 12:17, Fabian Hueske <fhue...@gmail.com> wrote: > >>>>>> > >>>>>> I compared the RC1 branch to the release-0.10.2 tag and went over > >> the > >>>> diff > >>>>>> (less than 2k changed lines, mostly added tests). > >>>>>> > >>>>>> Issues: > >>>>>> - the docs/_config.yml needs to be updated to version 0.10.2 > >>>>>> > >>>>>> Added / changed dependencies in pom files: > >>>>>> - Kryo was added to flink-storm > >>>>>> - ASM was added to flink-gelly-scala > >>>>>> - zkclient was added to flink-connector-kafka > >>>>>> - Netty was downgraded to version 4.0.27.Final in the root pom.xml > >>>>>> > >>>>>> All of these dependencies changes are fine because we had > >> dependencies > >>>> on > >>>>>> these artifacts already. > >>>>>> I did not see any added dependencies (web stuff, etc). > >>>>>> > >>>>>> -1 for the RC due to the non-updated docs config. However, I'd > >> suggest > >>>> to > >>>>>> continue testing this RC before creating a new one. > >>>>> > >>>>> We had this issue before with the docs. I would actually like to not > >>>> block the release on this, because the docs on the website are updated > >>> from > >>>> the 0.10 release branch anyways and this will only affect people who > >>> check > >>>> out the docs locally. > >>>>> > >>>>> If you insist or other people see this as a blocker as well, I can > >>>> certainly create another RC. > >>>>> > >>>>> – Ufuk > >>>>> > >>>>> PS: I’ve added a note to the releasing Wiki entry. > >>>>> > >>>> > >>> > >> > >
