+1 for the proposal! On Tue, Mar 17, 2015 at 4:35 PM Aljoscha Krettek <aljos...@apache.org> wrote:
> +1 > On Mar 17, 2015 12:28 PM, "Maximilian Michels" <m...@apache.org> wrote: > > > Another proposal in addition to the recent changes: How about we remove > the > > "fixed" attribute from the navigation of the docs? Then the nav will just > > scroll away and give space for the documentation. After all, how useful > is > > it to constantly have the Java and Scala doc links available? > > > > Actually, that's also the behavior for the rest of the website like in > > http://flink.apache.org/community.html > > > > On Tue, Mar 10, 2015 at 4:03 PM, Maximilian Michels <m...@apache.org> > > wrote: > > > > > Thanks for the feedback. Merged. > > > > > > On Tue, Mar 10, 2015 at 11:34 AM, Márton Balassi > > > <balassi.mar...@gmail.com> wrote: > > > > +1 > > > > > > > > On Tue, Mar 10, 2015 at 11:28 AM, Hermann Gábor < > reckone...@gmail.com> > > > > wrote: > > > > > > > >> Looks nice, +1 for the new one. > > > >> > > > >> On Tue, Mar 10, 2015 at 11:24 AM Maximilian Michels <m...@apache.org > > > > > >> wrote: > > > >> > > > >> > Seems like my smart data crawling web mail took the linked images > > out. > > > >> > So here we go again: > > > >> > > > > >> > New > > > >> > http://i.imgur.com/KK7fhiR.png > > > >> > > > > >> > Old > > > >> > http://i.imgur.com/kP2LPnY.png > > > >> > > > > >> > On Tue, Mar 10, 2015 at 11:17 AM, Stephan Ewen <se...@apache.org> > > > wrote: > > > >> > > Looks the same to me ;-) > > > >> > > > > > >> > > The mailing lists do not support attachments... > > > >> > > > > > >> > > On Tue, Mar 10, 2015 at 11:15 AM, Maximilian Michels < > > > m...@apache.org> > > > >> > wrote: > > > >> > > > > > >> > >> So here are the proposed changes. > > > >> > >> > > > >> > >> New > > > >> > >> > > > >> > >> > > > >> > >> Old > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >> If there are no objections, I will merge this by the end of the > > > day. > > > >> > >> > > > >> > >> Best regards, > > > >> > >> Max > > > >> > >> > > > >> > >> On Mon, Mar 9, 2015 at 4:22 PM, Hermann Gábor < > > > reckone...@gmail.com> > > > >> > >> wrote: > > > >> > >> > > > >> > >> > Thanks Gyula, that helps a lot :D > > > >> > >> > > > > >> > >> > Nice solution. Thank you Max! > > > >> > >> > I also support the reduced header size! > > > >> > >> > > > > >> > >> > Cheers, > > > >> > >> > Gabor > > > >> > >> > > > > >> > >> > On Mon, Mar 9, 2015 at 3:36 PM Márton Balassi < > > > >> > balassi.mar...@gmail.com> > > > >> > >> > wrote: > > > >> > >> > > > > >> > >> > > +1 for the proposed solution from Max > > > >> > >> > > +1 for decreasing the size: but let's have preview, I also > > > think > > > >> > that > > > >> > >> the > > > >> > >> > > current one is a bit too large > > > >> > >> > > > > > >> > >> > > On Mon, Mar 9, 2015 at 2:16 PM, Maximilian Michels < > > > >> m...@apache.org> > > > >> > >> > wrote: > > > >> > >> > > > > > >> > >> > > > We can fix this for the headings by adding the following > > CSS > > > >> rule: > > > >> > >> > > > > > > >> > >> > > > h1, h2, h3, h4 { > > > >> > >> > > > padding-top: 100px; > > > >> > >> > > > margin-top: -100px; > > > >> > >> > > > } > > > >> > >> > > > > > > >> > >> > > > In the course of changing this, we could also reduce the > > > size of > > > >> > the > > > >> > >> > > > navigation header in the docs. It is occupies too much > > space > > > and > > > >> > >> > > > doesn't have a lot of functionality. I'd suggest to half > > its > > > >> size. > > > >> > >> The > > > >> > >> > > > positioning at the top is fine for me. > > > >> > >> > > > > > > >> > >> > > > > > > >> > >> > > > Kind regards, > > > >> > >> > > > Max > > > >> > >> > > > > > > >> > >> > > > On Mon, Mar 9, 2015 at 2:08 PM, Hermann Gábor < > > > >> > reckone...@gmail.com> > > > >> > >> > > > wrote: > > > >> > >> > > > > I think the navigation looks nice this way. > > > >> > >> > > > > > > > >> > >> > > > > It's rather a small CSS/HTML problem that the header > > shades > > > >> the > > > >> > >> title > > > >> > >> > > > when > > > >> > >> > > > > clicking on an anchor link. > > > >> > >> > > > > (It's that the content starts at top, but there is the > > > header > > > >> > >> > covering > > > >> > >> > > > it.) > > > >> > >> > > > > > > > >> > >> > > > > I'm not much into web stuff, but I would gladly fix it. > > > >> > >> > > > > > > > >> > >> > > > > Can someone help me with this? > > > >> > >> > > > > > > > >> > >> > > > > On Sun, Mar 8, 2015 at 9:52 PM Stephan Ewen < > > > se...@apache.org > > > >> > > > > >> > >> > wrote: > > > >> > >> > > > > > > > >> > >> > > > >> I agree, it is not optimal. > > > >> > >> > > > >> > > > >> > >> > > > >> What would be a better way to do this? Have the main > > > >> navigation > > > >> > >> > > > (currently > > > >> > >> > > > >> on the left) at the top, and the per-page navigation > on > > > the > > > >> > side? > > > >> > >> > > > >> > > > >> > >> > > > >> Do you want to take a stab at this? > > > >> > >> > > > >> > > > >> > >> > > > >> On Sun, Mar 8, 2015 at 7:08 PM, Hermann Gábor < > > > >> > >> reckone...@gmail.com > > > >> > >> > > > > > >> > >> > > > >> wrote: > > > >> > >> > > > >> > > > >> > >> > > > >> > Hey, > > > >> > >> > > > >> > > > > >> > >> > > > >> > Currently following an anchor link (e.g. > > > #transformations > > > >> > >> > > > >> > < > > > >> > >> > > > >> > > > http://ci.apache.org/projects/flink/flink-docs-master/ > > > >> > >> > > > >> programming_guide.html#transformations > > > >> > >> > > > >> > >) > > > >> > >> > > > >> > results in the header occupying the top of the page, > > > thus > > > >> the > > > >> > >> > title > > > >> > >> > > > and > > > >> > >> > > > >> > some of the first lines cannot be seen. This is not > a > > > big > > > >> > deal, > > > >> > >> > but > > > >> > >> > > > it's > > > >> > >> > > > >> > user-facing and a bit irritating. > > > >> > >> > > > >> > > > > >> > >> > > > >> > Can someone fix it, please? > > > >> > >> > > > >> > > > > >> > >> > > > >> > (I tried it on Firefox and Chromium on Ubuntu 14.10) > > > >> > >> > > > >> > > > > >> > >> > > > >> > Cheers, > > > >> > >> > > > >> > Gabor > > > >> > >> > > > >> > > > > >> > >> > > > >> > > > >> > >> > > > > > > >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > > > > >> > > > > > >
