I think in the refactor I'm working on it will be easier for Jewel to use the
Basic one and alter those few things.
-Alex
On 1/31/20, 10:59 AM, "Carlos Rovira" <carlosrov...@apache.org> wrote:
Hi Alex,
the problem is in dataProviderChangeHandler method
Basic is adding styles just in case like this:
var style:SimpleCSSStyles = new SimpleCSSStyles();
style.marginBottom = presentationModel.separatorThickness;
UIBase(ir).style = style;
while Jewel tries to minimize (or remove at all) any set of styles and uses
CSS
As well
UIBase(ir).percentWidth = 100;
is removed too.
another thing is
dataGroup.addItemRenderer(ir, false);
is executed at in other order in other place, I think I need to do that for
some reason, but don't remember why
For that reason, I was proposing to refactor to extend the basic one.
What do you think?
El vie., 31 ene. 2020 a las 18:09, Alex Harui (<aha...@adobe.com.invalid>)
escribió:
> Hi Carlos,
>
> The diff I ran didn't show anything obvious. And as you noted in another
> email, there is a copy of DateChooserModel in Jewel I didn't see that I
> will fix shortly.
>
> Are we still concerned about re-use of Basic beads? I thought all visual
> CSS from Basic was moved to a Theme. It may also be that we need to get
> better at using interfaces (and the "has" pattern) and maybe more of these
> beads and models can go in Core or maybe some other SWC.
>
> -Alex
>
> On 1/31/20, 4:01 AM, "Carlos Rovira" <carlosrov...@apache.org> wrote:
>
> Hi Alex,
> I've missed this email, sorry. I was comparing code and there's
various
> changes most of all at the end of the file that are important for
> Jewel,
> I can try to make it extend the Basic Bead and see if that's possible
> and
> saves something
>
> El mié., 29 ene. 2020 a las 20:48, Alex Harui
> (<aha...@adobe.com.invalid>)
> escribió:
>
> > @Carlos,
> >
> > While we're on the subject, it appears that Jewel has an actual copy
> of,
> > for example, Basic's DataItemRendererFactoryForArrayData. What is
> the
> > rationale for that? Is there some subtle difference I'm not seeing
> or can
> > we get rid of the duplicate copy?
> >
> > -Alex
> >
> > On 1/29/20, 8:46 AM, "Carlos Rovira" <carlosrov...@apache.org>
> wrote:
> >
> > It's ok to change it if other changes done this past months make
> MDL
> > DDL
> > continue to work
> > Maybe others are using it since is a full working set and we
> should
> > ensure
> > it continue to work
> > thanks
> >
> > El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
> > piotrzarzyck...@gmail.com>) escribió:
> >
> > > Hi Alex,
> > >
> > > I remember that DropDownl list was lack of dataField actually.
> > Instead of
> > > adding it trough property - I have created Bead which provides
> that
> > > feature. Whether it's needed now or not is actually something
> I have
> > no
> > > idea about. I'm ok with removing it.
> > >
> > >
> > > wt., 28 sty 2020 o 20:55 Alex Harui <aha...@adobe.com>
> napisał(a):
> > >
> > > > Ran into this while doing the has/is refactor.
> > > >
> > > > In what ways is this different than the labelField in
> > IDataProviderModel?
> > > >
> > > > Thanks,
> > > > -Alex
> > > >
> > > > On 6/29/17, 12:22 PM, "pio...@apache.org" <pio...@apache.org
> >
> > wrote:
> > > >
> > > > FLEX-35328 - Update MDLExample with
DataFieldProviderBead
> > > >
> > > >
> > > > Project:
> > > >
> > >
> >
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=i3HkbrgC70ldpEK9Iz10gR3uqx7c6YtART2MztgHUDk%3D&reserved=0
> > > > Commit:
> > > >
> > >
> >
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=4Li%2B6iFmgCrk3tN80k3YPx00IuI%2BVrQmida539LhTWQ%3D&reserved=0
> > > > Tree:
> > > >
> > >
> >
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=JsqoVpRY065kpLJIjRgjfoW6Uvuwuz1bRvfOmASLpVw%3D&reserved=0
> > > > Diff:
> > > >
> > >
> >
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=fzIoWxBZMCGKliSLxWVfAlNXcItqRpTzORMXmw8rHRU%3D&reserved=0
> > > >
> > > > Branch: refs/heads/develop
> > > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > > > Parents: eaa33ea
> > > > Author: piotrz <pio...@apache.org>
> > > > Authored: Sun Jun 25 19:27:09 2017 +0200
> > > > Committer: piotrz <pio...@apache.org>
> > > > Committed: Sun Jun 25 19:27:09 2017 +0200
> > > >
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > >
> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
> > 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > >
> > > >
> > > >
> > > >
> > >
> >
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=V9rZVYuGWDkpdsNdd6HwXGqtyPYv4z4xB%2FvNkMNUMPs%3D&reserved=0
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > > diff --git
> > > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > index 14d14fd..4231328 100644
> > > > ---
> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > +++
> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > @@ -38,7 +38,7 @@ limitations under the License.
> > > > sourceID="menuModel"
> > > >
sourcePropertyName="menuItems"
> > > >
> > destinationPropertyName="dataProvider" />
> > > > - <models2:DataFieldProviderModel
> > > dataField="value"/>
> > > > + <js:DataFieldProviderBead
> > dataField="value"/>
> > > > </mdl:beads>
> > > > </mdl:DropDownList>
> > > > </mdl:GridCell>
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *
> >
>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=ROxl8Q7DQF6FTj%2FJyS1wx4zF4OjIX2%2Bm%2BBvt5S1PeF8%3D&reserved=0
> > > <
> >
>
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=%2F4CI0cQdx%2BBWqZkfQDBMU9GD54XqTqc%2FO7VuymE1IZs%3D&reserved=0
> > >*
> > >
> >
> >
> > --
> > Carlos Rovira
> >
> >
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=YnoJ8VomKpTSH1%2F2%2B0GSuvNHZVHqHk47LfvhwvasUac%3D&reserved=0
> >
> >
> >
>
> --
> Carlos Rovira
>
>
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=YnoJ8VomKpTSH1%2F2%2B0GSuvNHZVHqHk47LfvhwvasUac%3D&reserved=0
>
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=YnoJ8VomKpTSH1%2F2%2B0GSuvNHZVHqHk47LfvhwvasUac%3D&reserved=0
