It's ok to change it if other changes done this past months make MDL DDL
continue to work
Maybe others are using it since is a full working set and we should ensure
it continue to work
thanks

El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
piotrzarzyck...@gmail.com>) escribió:

> Hi Alex,
>
> I remember that DropDownl list was lack of dataField actually. Instead of
> adding it trough property - I have created Bead which provides that
> feature. Whether it's needed now or not is actually something I have no
> idea about. I'm ok with removing it.
>
>
> wt., 28 sty 2020 o 20:55 Alex Harui <aha...@adobe.com> napisał(a):
>
> > Ran into this while doing the has/is refactor.
> >
> > In what ways is this different than the labelField in IDataProviderModel?
> >
> > Thanks,
> > -Alex
> >
> > On 6/29/17, 12:22 PM, "pio...@apache.org" <pio...@apache.org> wrote:
> >
> >     FLEX-35328 - Update MDLExample with DataFieldProviderBead
> >
> >
> >     Project:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=BE4Z7ZcUMq%2FhFpeKmsQUAeqzgHHQ4fBT5JKJGOAQXLQ%3D&reserved=0
> >     Commit:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=18wyjAOAvTeMBC41hZK32BZ5yEBwL0q3eY6aOedltVo%3D&reserved=0
> >     Tree:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=oizDT4asGP%2F3V4FKy2otyMW5PqmufwThJblkaC2YmKk%3D&reserved=0
> >     Diff:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=gadfSlqR%2BTh%2F5pirsxkEvSjF9PnrZO2mlIlhlWiNrpY%3D&reserved=0
> >
> >     Branch: refs/heads/develop
> >     Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> >     Parents: eaa33ea
> >     Author: piotrz <pio...@apache.org>
> >     Authored: Sun Jun 25 19:27:09 2017 +0200
> >     Committer: piotrz <pio...@apache.org>
> >     Committed: Sun Jun 25 19:27:09 2017 +0200
> >
> >
>  ----------------------------------------------------------------------
> >      examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml | 2 +-
> >      1 file changed, 1 insertion(+), 1 deletion(-)
> >
>  ----------------------------------------------------------------------
> >
> >
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=QBzrdEaKyzEBxXfodisqDQFthzf0%2FXwKB6GE22q9c2Y%3D&reserved=0
> >
>  ----------------------------------------------------------------------
> >     diff --git
> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >     index 14d14fd..4231328 100644
> >     --- a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >     +++ b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >     @@ -38,7 +38,7 @@ limitations under the License.
> >                                sourceID="menuModel"
> >                                sourcePropertyName="menuItems"
> >                                destinationPropertyName="dataProvider" />
> >     -                  <models2:DataFieldProviderModel
> dataField="value"/>
> >     +                  <js:DataFieldProviderBead dataField="value"/>
> >                    </mdl:beads>
> >                </mdl:DropDownList>
> >              </mdl:GridCell>
> >
> >
> >
> >
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>


-- 
Carlos Rovira
http://about.me/carlosrovira

Reply via email to