Yes, after the Maven build failed, I saw that the other MXML tests were
excluded, and I excluded my new ones in the same place. The Maven side has
no problems with my changes anymore. Just gotta tweak the Ant build a bit.
If we find the time to come up with better tests in Miami, that would be
cool.
I have some ideas for how to run my new tests without the asjs dependency.
Basically, it involves creating a couple of custom AS/MXML classes to
reference in MXML instead of real components from the framework. The exact
classes referenced in MXML don't matter for my tests. It was simply
convenient to follow the patterns of the existing tests to get it written
quickly. These custom classes could probably be used to improve some of
those other tests too.
- Josh
On Mar 27, 2017 1:04 PM, "Christofer Dutz" <christofer.d...@c-ware.de>
wrote:
Hi Josh,
I guess in that case it was one of the tests which I excluded from the
Maven build … so if you add another it will automatically be run, as Maven
doesn’t know it should exclude it. If you have a look in the pom.xml you
will see the surefire plugin (runs unit tests) and the failsafe plugin
(runs integration tests). Here a hand full of tests are excluded because
they need a refactoring to not introduce a cycle or need to be moved to the
framework module (I would prefer the first option)
Guess it would be cool if we figured out a way to refactor the tests so we
can run them in Maven … eventually doing so over a beer in Miami would be a
good invest of time? What do you think ;-)
Chris
Am 27.03.17, 17:43 schrieb "Josh Tynjala" <joshtynj...@gmail.com>:
I didn't structure the tests this way. I followed the existing tests
that
were already there.
- Josh
On Mar 27, 2017 1:04 AM, "Christofer Dutz" <christofer.d...@c-ware.de>
wrote:
> Hi Josh,
>
> Tests shouldn’t require a directory structure … especially not
outside of
> the current maven modules directory. This type of refactoring is what
> consumed most of my time while migrating Falcon from Ant to Maven.
Having a
> look at the current problem, it seems the problems are related to its
> dependency to FlexJSTestBase, which seems to require a set of
environment
> variables and expects other directories. This dependency to framework
would
> have introduced a cycle, which is also the reason I couldn’t refactor
the
> tests without completely re-writing most of them.
>
> We should address the FlexJsTestBase tests and make sure we are able
to
> test what they should be testing without introducing a cyclic
dependency.
>
> For now, excluding them from the testsuite is probably the best
option.
>
> Chris
>
>
> Am 26.03.17, 23:19 schrieb "Josh Tynjala" <joshtynj...@gmail.com>:
>
> 1. I don't think this part is actually an issue (other than being
> annoying
> noise in the output). I also see this warning and my build
finishes
> successfully.
>
> 2/3. I think these new tests that I wrote rely on flex-asjs in
some way
> (since they're parsing MXML), and maybe it's having trouble
finding
> that
> project on your machine. I'll see if I can move them to the
correct
> part of
> the build where it runs the optional "dependent" tests.
>
> - Josh
>
> On Sun, Mar 26, 2017 at 1:53 PM, Harbs <harbs.li...@gmail.com>
wrote:
>
> > There seemed to be three things causing me build problems:
> > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
> test/FlexJSTestBase.java
> > A reference to frameworks/as/basic-manifest.xml which does not
seem
> to
> > exist.
> > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
> > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests
are
> > failing.
> > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/
> > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests
are
> > failing.
> >
> > Removing the test in 1 and the latter two files allowed Falcon
and
> asjs to
> > build on my machine.
> >
> > Harbs
> >
> > > On Mar 26, 2017, at 11:26 PM, Harbs <harbs.li...@gmail.com>
wrote:
> > >
> > > I’m also having trouble building, but it’s failing at a
totally
> > different place.
> > >
> > >> On Mar 26, 2017, at 11:08 PM, piotrz <
piotrzarzyck...@gmail.com>
> wrote:
> > >>
> > >> Hi Harbs,
> > >>
> > >> This is stack trace is straight from jenkins build.
> > >>
> > >> Locally I have same fail and definitely I did build with
fresh
> sources
> > of
> > >> Falcon.
> > >>
> > >> Piotr
> > >>
> > >>
> > >>
> > >> -----
> > >> Apache Flex PMC
> > >> piotrzarzyck...@gmail.com
> > >> --
> > >> View this message in context: http://apache-flex-
> > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on-
> > the-build-problems-tp60777p60789.html
> > >> Sent from the Apache Flex Development mailing list archive at
> > Nabble.com.
> > >
> >
> >
>
>
>
