I didn't structure the tests this way. I followed the existing tests that were already there.
- Josh On Mar 27, 2017 1:04 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote: > Hi Josh, > > Tests shouldn’t require a directory structure … especially not outside of > the current maven modules directory. This type of refactoring is what > consumed most of my time while migrating Falcon from Ant to Maven. Having a > look at the current problem, it seems the problems are related to its > dependency to FlexJSTestBase, which seems to require a set of environment > variables and expects other directories. This dependency to framework would > have introduced a cycle, which is also the reason I couldn’t refactor the > tests without completely re-writing most of them. > > We should address the FlexJsTestBase tests and make sure we are able to > test what they should be testing without introducing a cyclic dependency. > > For now, excluding them from the testsuite is probably the best option. > > Chris > > > Am 26.03.17, 23:19 schrieb "Josh Tynjala" <joshtynj...@gmail.com>: > > 1. I don't think this part is actually an issue (other than being > annoying > noise in the output). I also see this warning and my build finishes > successfully. > > 2/3. I think these new tests that I wrote rely on flex-asjs in some way > (since they're parsing MXML), and maybe it's having trouble finding > that > project on your machine. I'll see if I can move them to the correct > part of > the build where it runs the optional "dependent" tests. > > - Josh > > On Sun, Mar 26, 2017 at 1:53 PM, Harbs <harbs.li...@gmail.com> wrote: > > > There seemed to be three things causing me build problems: > > 1. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > test/FlexJSTestBase.java > > A reference to frameworks/as/basic-manifest.xml which does not seem > to > > exist. > > 2. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLScript.java The tests are > > failing. > > 3. compiler-jx/src/test/java/org/apache/flex/compiler/internal/ > > codegen/mxml/sourcemaps/TestSourceMapMXMLEvents.java The tests are > > failing. > > > > Removing the test in 1 and the latter two files allowed Falcon and > asjs to > > build on my machine. > > > > Harbs > > > > > On Mar 26, 2017, at 11:26 PM, Harbs <harbs.li...@gmail.com> wrote: > > > > > > I’m also having trouble building, but it’s failing at a totally > > different place. > > > > > >> On Mar 26, 2017, at 11:08 PM, piotrz <piotrzarzyck...@gmail.com> > wrote: > > >> > > >> Hi Harbs, > > >> > > >> This is stack trace is straight from jenkins build. > > >> > > >> Locally I have same fail and definitely I did build with fresh > sources > > of > > >> Falcon. > > >> > > >> Piotr > > >> > > >> > > >> > > >> ----- > > >> Apache Flex PMC > > >> piotrzarzyck...@gmail.com > > >> -- > > >> View this message in context: http://apache-flex- > > development.2333347.n4.nabble.com/FlexJS-Anyone-working-on- > > the-build-problems-tp60777p60789.html > > >> Sent from the Apache Flex Development mailing list archive at > > Nabble.com. > > > > > > > > > >
