I got this working quite quickly for the charts but also experienced issues with FlexJSStore bulding, which I have since addressed.
I am just checking all examples - the ant build of all examples now completes, I just want to visually check them all - and then I will run a full set of tests before pushing the fix. On Thu, Sep 29, 2016 at 7:44 AM, Greg Dove <greg.d...@gmail.com> wrote: > I will look at this now. > > I had intended for relection to always be at the end, so that definitely > sounds wrong. > I did find the usedNames/postProcess sequence to be a possible candidate > for refactor at some point, but was not keen to mess with this at the > moment. I think I found that some usedNames were not being added to > goog.requires as it was originally. > > > > On Thu, Sep 29, 2016 at 7:33 AM, Alex Harui <aha...@adobe.com> wrote: > >> Looked into it. It appears to be related to Greg's changes in >> 0bde1ec7a47341294280082331ce8b2c023d756f >> >> In MXMLFlexJSEmitter, the namesToAdd is including internal classes which >> it shouldn't. Probably the subDocuments list can be used to further >> filter what gets added to namesToAdd. >> >> Also, the reflection data for internal classes is being emitted at the top >> of the output file. That should probably get changed as well. >> >> I'm going back to other things. I expect Greg will take care of this. >> Greg, let us know if you need help or don't have time. >> >> -Alex >> >> On 9/28/16, 9:40 AM, "Alex Harui" <aha...@adobe.com> wrote: >> >> >The Ant build doesn't build the examples. Maybe it should. The >> >ChartExample fails for me from Ant as well. I will look into it. >> > >> >-Alex >> > >> >On 9/28/16, 2:30 AM, "Christofer Dutz" <christofer.d...@c-ware.de> >> wrote: >> > >> >>Ok now the modules that were failing compile successfully. Unfortunately >> >>now a little more down the stream the examples seem to be failing. I am >> >>getting errors in the chart example (just the first example to be >> >>compiled) It seems the JS compilation is failing because it cant find >> >>generated classes. >> >> >> >> >> >>https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20 >> Framework%20(ma >> >>v >> >>en)/269/console >> >> >> >> >> >>Did anything change in this part recently? >> > >> >> >
