OK, looking forward to seeing it. -Alex
On 9/13/16, 10:58 PM, "Greg Dove" <greg.d...@gmail.com> wrote: >Alex, just a quick update on this.... >I didn't get to work on this as much over the weekend as I'd hoped, but I >have progressed it since. I iterated through a few different approaches >for >various aspects of the reflection stuff, but I have settled on what I >think >is a good output type for js, There was (as there always is) a bit more to >it than I'd thought, but I am getting there. I also encountered some >unrelated js output bugs (missing goog.requires causing some things to be >undefined) which I have been distracted by today and have also made >progress on. > >Anyhow, I will test things a bit more tomorrow and hopefully have >something >I can push towards the end of tomorrow. If not, I expect it will be the >following day. > >cheers, >Greg > > > >On Fri, Sep 9, 2016 at 5:04 PM, Greg Dove <greg.d...@gmail.com> wrote: > >> Good to know. Pretty sure there is nothing outside of reflection here, >>so >> that sounds great.- thanks >> >> >> On Fri, Sep 9, 2016 at 4:59 PM, Alex Harui <aha...@adobe.com> wrote: >> >>> >>> >>> On 9/8/16, 9:50 PM, "Greg Dove" <greg.d...@gmail.com> wrote: >>> >>> >What is your preference for me getting this into the repo? If all >>>current >>> >(updated) tests pass and nothing else seems broken is it ok if I push >>>to >>> >develop for jx and asjs? Or do you prefer I go to branches on both >>>until >>> >it >>> >can be checked by you or others - it will be something where both >>>repos >>> >will need to update at the same time I think. >>> > >>> >>> If there is little risk it will break things not related to >>>reflection, I >>> would just check it in. Not too many folks are using reflection. IMO, >>> remote branches are for sharing work in progress: things that will take >>> several days and commits to get done. If you are all done except for a >>> bug or two, it can just go in, especially this early in the next >>>release >>> cycle. >>> >>> We get commit emails and are supposed to review then anyway. >>> >>> -Alex >>> >>> >>
