Good to know. Pretty sure there is nothing outside of reflection here, so that sounds great.- thanks
On Fri, Sep 9, 2016 at 4:59 PM, Alex Harui <aha...@adobe.com> wrote: > > > On 9/8/16, 9:50 PM, "Greg Dove" <greg.d...@gmail.com> wrote: > > >What is your preference for me getting this into the repo? If all current > >(updated) tests pass and nothing else seems broken is it ok if I push to > >develop for jx and asjs? Or do you prefer I go to branches on both until > >it > >can be checked by you or others - it will be something where both repos > >will need to update at the same time I think. > > > > If there is little risk it will break things not related to reflection, I > would just check it in. Not too many folks are using reflection. IMO, > remote branches are for sharing work in progress: things that will take > several days and commits to get done. If you are all done except for a > bug or two, it can just go in, especially this early in the next release > cycle. > > We get commit emails and are supposed to review then anyway. > > -Alex > >
