On 7/2/16, 10:34 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> IMO, because the patch files are generated from ant scripts, they don't >> need headers. > >IMO if it source code it need a header, otherwise how do we know how the >patch is licensed or where it come from? > >This same issue was also brought up on an incubating release recently. [1] I didn't see mention in [1] that those patches were generated from a script, so I would agree that the podling's patches should have headers. I could insert a line in our patch files that it is generated. Would that be sufficient? I know it is a bit odd to have generated-sources in the source package, but we are doing that to make the Maven build work without having to have its own patch-generation mechanism. Thoughts? -Alex > >Thanks, >Justin > >1. >https://lists.apache.org/thread.html/b84920dcb1f62ca408d0edbe888411830be31 >3899a5da705fbeffae1@%3Cgeneral.incubator.apache.org%3E >
