IMO, because the patch files are generated from ant scripts, they don't need headers. And because the patches ares a modification to CreateJS, it is ASF content, not CreateJS content, so I didn't mention CreateJS in the LICENSE since none of their IP is bundled. In the binary package, CreateJS is bundled and you should find CreateJS in LICENSE.
Similar for google_maps and other patch files. Thoughts? -Alex On 7/2/16, 8:58 PM, "Justin Mclean" <jus...@classsoftware.com> wrote: >Hi, > >I took a quick look at the source releases: > >For Falcon: >- The LICENSE file is missing MIT licensed creatjs / easeljs / tweenjs >[1][2] >- I’m not sure how some files have this (e.g. [X]) is "Copyright >2001-2005 The Apache Software Foundation”. The dates are odd and it’s >unusual for a source file to have an ASF header with a copyright ASF line >in it.[8] Note that the policy states "note that there should be no >copyright notice in the header”. >- Some patch files are missing ASF headers (it sure right?) and may >require modification to LICENSE if there’s 3rd party code in there? [5] > >For FalconJX: >- same three issues as above > >For FlexJS: >- examples have copyright 2015 in app xml files e.g. [4] > >Thanks, >Justin > >1 ./externs/createjs/src/main/patch/easeljs.patch >2 ./externs/createjs/src/main/patch/tweenjs.patch >3. ./compiler/src/test/java/utils/FlashplayerSecurityHandler.java >4. ./examples/flexjs/CordovaCameraExample/CordovaCameraExample-app.xml >5. ./externs/google_maps/src/main/patch/google_maps.patch >6. ./externs/jquery/src/main/patch/jquery.patch >7. ./externs/js/src/main/patch/js.patch >8. http://www.apache.org/legal/src-headers.html#headers
