Hi Alex,
Actually, I removed all the js files from the compilation path in order to
re-code them one by one in as3, so, all the existing classes already in as3, I
wrapped them with COMPILE::AS3 because for sure the output artefact for them
will be .swc
I started to convert the Application sub components to as3 wrapping them with
COMPILE:JS because the output artefact for them will be .js
Does it makes sense ?
Note:
1- Those core classes in JS have been modified in the master branch, so, my
conversion is not in sync
2- I had t2 issues with the GCL.swc and Falcon, the one I mentioned relative to
the getter / setter at package level and another one I haven't in mind at the
moment but will describe tomorrow, proving more details about the GCL.swc
Frédéric THOMAS
> From: aha...@adobe.com
> To: dev@flex.apache.org
> Subject: Re: [FlexJS] Framework using externs (was: Setup Error)
> Date: Wed, 16 Sep 2015 16:54:06 +0000
>
> Hi Fred,
>
> I started poking around in the branch. I’m confused by how you plan to
> use the conditional compilation flags. Whole classes seem to be marked
> with COMPILE::AS3, but I would expect any conditional compilation to be on
> or inside methods. Can you explain?
>
> Thanks,
> -Alex
>
> On 9/16/15, 2:26 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote:
>
> >Hi Alex,
> >
> >Cool, Btw, I didn't fix the bug I had with the flex-oem-compiler yet
> >given I will move those things to IJ, neither the one regarding the
> >getter / setter functions at package level.
> >
> >I will share the CGL.swc with its sources and details as soon as I can,
> >probably tomorrow along with the Ant targets using the compiler.clients.*
> >
> >Thanks,
> >Frédéric THOMAS
> >
> >> From: aha...@adobe.com
> >> To: dev@flex.apache.org
> >> Subject: Re: [FlexJS] Framework using externs (was: Setup Error)
> >> Date: Wed, 16 Sep 2015 06:08:33 +0000
> >>
> >> FYI, I’m going to start finding time to work on this port.
> >>
> >> -Alex
> >>
> >> On 9/9/15, 6:19 AM, "Alex Harui" <aha...@adobe.com> wrote:
> >>
> >> >
> >> >
> >> >On 9/9/15, 3:12 AM, "Frédéric THOMAS" <webdoubl...@hotmail.com> wrote:
> >> >
> >> >>
> >> >>One thing I discovered though is that with Falcon, the combination of
> >> >>getter / setter for a same function at package level is not supported
> >> >>(the legacy compiler support it):
> >> >>
> >> >>package goog.events {
> >> >>public function get fireListener():Function{return null;}
> >> >>public function set fireListener(value:Function):void{}
> >> >>}
> >> >>
> >> >>Error: An externally-visible definition with the name
> >> >>'goog.events.fireListener' was unexpectedly found.
> >> >>
> >> >>Can you take care of it or drive me into fixing it ?
> >> >
> >> >That’s interesting. I’ve never seen a ‘global’ property in AS before.
> >> If
> >> >you want to try to fix it, what I would do is set a breakpoint in
> >> >CompilerProblem.java. Then you’ll see on the call stack what logic
> >> >decided to generate that error and can try to add other logic to
> >>accept it
> >> >in this case.
> >> >
> >> >Speaking of doing things like that, it occurred to me recently that
> >> >ambiguous definition errors when the global Event class conflicts with
> >> >org.apache.flex.events.Events could be handled by adjusting the logic
> >>for
> >> >detecting ambiguous definitions. IIRC, the logic resolves the “Event”
> >>and
> >> >if it finds more than one definition it generates the error. The logic
> >> >could be adjusted to see if one of the definitions is a global
> >>definition
> >> >and then use the global and maybe additionally generate a warning
> >>instead
> >> >of an error.
> >> >BTW, it looks like this week and next will be spent on getting a
> >>release
> >> >out the door, then I hope to work on this port from JS to AS.
> >> >
> >> >-Alex
> >> >
> >>
> >
>
