IMO, if it ain’t broke, don’t fix it. But I’ll let Erik make the call since he’s the RM. Every change made risks another mistake. I’m signing off for tonight. I’ll see what you guys think when I wake up.
A few more comments in-line. On 1/3/15, 12:07 AM, "Justin Mclean" <jus...@classsoftware.com> wrote: >Any Apache 2.0 should not be normally added to license. As the document >states under "Bundling an Apache-2.0-licensed Dependency" there is no >need to modify LICENSE. Yes, but separately, Sebb recommended listing subcomponents. http://s.apache.org/2uz >>>6. Need to add WC3 see [6] >> >> I puzzled over this for a while and still am not sure of the answer. > >Basically if we omit it's most likely a licensing error (as the LICENSE >file must contain all licenses of all bundled software), but if we add it >there's no error. I can add this. Look at the W3C licensing in >xml-apis-ext.jar and xml-apis.jar. Are you proposing to add the entire text of W3C to LICENSE or a pointer to a separate file stored somewhere? Are you also claiming that Batik’s NOTICE is wrong? That’s where we get xml-apis*.jar. >>I don’t think it is our problem to resolve issues in Xalan’s NOTICE. The >> README files don’t seem to be in the binary package we use. > >We can point it out to them and it easy to fix ie remove a few lines. >Again I can do that. What changes are you proposing to make here? > >>> 6. Missing some notices from xerces (there are several NOTICE files) >> >> I think I got them all. Which ones did I miss? > >It should be: > Portions of this software were originally based on the following: > - software copyright (c) 1999, IBM Corporation., http://www.ibm.com. > - software copyright (c) 1999, Sun Microsystems., http://www.sun.com. > - voluntary contributions made by Paul Eng on behalf of the > Apache Software Foundation that were originally developed at >iClick, Inc., > software copyright (c) 1999. Yep, missed that. Checked it in. > >Portions of this code are derived from classes placed in the >public domain by Arbortext on 10 Apr 2000. See: >http://www.arbortext.com/customer_support/updates_and_technical_notes/cata >logs/docs/README.htm The portion below is already in for Xalan isn’t it? It is unclear whether it needs to be duplicated or not. > > Portions of this software was originally based on the following: > - software copyright (c) 1999-2002, Lotus Development Corporation., > http://www.lotus.com. > - software copyright (c) 2001-2002, Sun Microsystems., > http://www.sun.com. > - software copyright (c) 2003, IBM Corporation., > http://www.ibm.com. > >>> 7. Missing required notices from XML commons extensions > >xml-apis-ext.jar > >The NOTICE should include: > Portions of this software were originally based on the following: > - software copyright (c) 1999, IBM Corporation., http://www.ibm.com. > - software copyright (c) 1999, Sun Microsystems., http://www.sun.com. > - software copyright (c) 2000 World Wide Web Consortium, >http://www.w3.org Did you get this from the jar or somewhere else? Thanks, -Alex
