Test results will definitely be helpful. Of course, we may not have tests for every case in this code path. I spent a few minutes looking at the patch and the entire file. I haven’t stepped through the test cases. I can see why changing the return value could fix this test case, but if someone is going to dig deeper, I would suggest trying to see if there are cases where that code path should return the true. It looks like the semantics of the return value has to do with whether the range gets adjusted or not. Maybe clampToFit needs to return whether it adjusted the range and that would dictate whether false is returned in the test case scenario.
-Alex On 10/15/14, 7:41 AM, "piotrz" <piotrzarzyck...@gmail.com> wrote: >Erik, > >If you pushed it to the develop branch let's wait for jenkins build and >see >whether existing Unit Tests pass through without a problem on TLF. I think >It will be also some information whether this patch break something or >not. > >Piotr > > > >----- >Apache Flex PMC >piotrzarzyck...@gmail.com >-- >View this message in context: >http://apache-flex-development.2333347.n4.nabble.com/Re-git-commit-flex-tl >f-refs-heads-develop-FLEX-34403-fix-Right-arrow-never-works-when-text-sele >cted--tp41400p41416.html >Sent from the Apache Flex Development mailing list archive at Nabble.com.
