Agreed. I did track that through line by line in multiple scenarios but there could be some cases I missed which is why I asked if someone with more knowledge of TLF could take a look. The patch is super simple (changed a true to false) so it's really easy to revert if needed.
Neil -----Original Message----- From: Erik de Bruin [mailto:e...@ixsoftware.nl] Sent: October-15-14 5:24 AM To: dev@flex.apache.org Subject: Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix "Right arrow never works when text selected in TextInput" (credit: Neil Madsen) The patch is already applied. Feel free to revert if I missed something and it turns out the "fix" breaks stuff (or doesn't fix the actual problem ;-)) EdB On Wed, Oct 15, 2014 at 12:04 PM, Harbs <harbs.li...@gmail.com> wrote: > I will take a look at this next week and apply it if it's okay. > > On Oct 15, 2014, at 10:24 AM, Justin Mclean <justinmcl...@me.com> wrote: > > > HI, > > > > Think this needs to be carefully tested before being applied, it > > doesn't > look like the correct fix to me (and I'd remove the commented out line). > > > > Anyone who knows TLF better than I have an opinion on this "fix"? > > > > Thanks, > > Justin > > > > On 15 Oct 2014, at 5:53 pm, erikdebr...@apache.org wrote: > > > >> Repository: flex-tlf > >> Updated Branches: > >> refs/heads/develop 553c899e5 -> 80f3042db > >> > >> > >> FLEX-34403 - fix "Right arrow never works when text selected in > TextInput" (credit: Neil Madsen) > >> > >> Signed-off-by: Erik de Bruin <e...@ixsoftware.nl> > >> > >> > >> Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo > >> Commit: > >> http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d > >> Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d > >> Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d > >> > >> Branch: refs/heads/develop > >> Commit: 80f3042db978557183109deb8231a6d84853d657 > >> Parents: 553c899 > >> Author: Erik de Bruin <e...@ixsoftware.nl> > >> Authored: Wed Oct 15 08:53:26 2014 +0200 > >> Committer: Erik de Bruin <e...@ixsoftware.nl> > >> Committed: Wed Oct 15 08:53:26 2014 +0200 > >> > >> ------------------------------------------------------------------- > >> --- textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3 > >> ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> ------------------------------------------------------------------- > >> --- > >> > >> > >> > http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayo > ut/src/flashx/textLayout/utils/NavigationUtil.as > >> ------------------------------------------------------------------- > >> --- diff --git > >> a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as > b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as > >> index 2ebb985..091ceda 100644 > >> --- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as > >> +++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as > >> @@ -1112,7 +1112,8 @@ package flashx.textLayout.utils > >> if (range.absoluteEnd >= > flowComposer.damageAbsoluteStart - 1) > >> { > >> clampToFit(range, > flowComposer.damageAbsoluteStart - 1); > >> - return true; > >> + return false; > >> + //return true; > >> } > >> if (flowComposer && flowComposer.numControllers) > >> { > >> > > > > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
