On 3/9/14 9:50 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:

>Hi,
>
>> So while we have enough +1 votes,
>Not quite there's only 2 + binding votes but you haven't voted.
>
>> the question is: how often do we expect to get errors fetching these
>>xml files?
>Are you sure that's the issue in Maurice's case?
Pretty sure.  I will try to reproduce it.  The error handler just switches
to the directory state.  That's because the installer-config.xml file was
optional.  But later I changed the sdk-installer-config-4.0 so we know
whether the installer-config.xml file should be there or not and didn't
modify the error handler.  I think I will change it to abort the install.
>
>I can't see how  unable to load the XML file would cause the optional
>licence items to go missing but the others remain.
Because it reverts to legacy SDK install mode currently.

BTW, if the sdk-installer-config-4.0.xml file fails to load, it is now
loaded so early we don't have any localized strings loaded (since we get
the list of locales from this file).  So I think the best we can do now is
to log something hard coded in US english.  Sound ok?

-Alex

Reply via email to