Hi,
First, I can confirm that Om's suggestion of *adding* the createElement
override to the cross-compiled/generated BarChart.js does fix the problem.
Secondly - how do we make it possible to allow customization of the
JavaScript that gets cross-compiled? This is bound to be necessary and
clearly solves this problem.
A bunch of things popped into my head:
1. We add createElement to UIBase.as so there is parity with the
JavaScript code. We might actually make good use of this on the AS side,
but I haven't given that any thought. Having it though, would allow the AS
BarChart to override the method and introduce AS code that would get
cross-compiled into JavaScript.
2. We need to be able to programmatically set style properties that get
cross-compiled correctly. The key to the BarChart issue is
"this.element.style.overflow = 'visible';" or setting the overflow style
to "visible". Perhaps something like: this.style = "overflow"; on the
ActionScript side would coax the compiler to generate the
"this.element.style.overflow = 'visible';" on the JavaScript side.
3. Allow JavaScript-specific code to be placed in the ActionScript code,
maybe using metadata:
override public function createElement()
{
[JavaScript]
this.element = document.createElement('div');
this.element.style.overflow = 'visible';
this.positioner = this.element;
[JavaScript]
[ActionScript]
// code within these [ActionScript] tags does not get cross-compiled
[ActionScript]
}
We really do need to have some way to tweak the JavaScript code, whether
it be styling or something else.
--peter
On 1/31/14 3:24 AM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote:
>On Jan 30, 2014 11:32 PM, "Alex Harui" <aha...@adobe.com> wrote:
>>
>>
>>
>> On 1/30/14 11:07 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote:
>>
>> >On Jan 30, 2014 10:18 PM, "Alex Harui" <aha...@adobe.com> wrote:
>> >>
>> >>
>> >>
>> >> On 1/30/14 9:11 PM, "OmPrakash Muppirala" <bigosma...@gmail.com>
>>wrote:
>> >>
>> >> >On Thu, Jan 30, 2014 at 8:30 PM, Alex Harui <aha...@adobe.com>
>>wrote:
>> >> >
>> >> >> Om, something is still not configured right. BarChart.js should
>>be
>> >> >>coming
>> >> >> from frameworks/js/FlexJS/libs.
>> >> >
>> >> >
>> >> >I dont see the libs folder here:
>> >> >
>> >
>https://git-wip-us.apache.org/repos/asf?p=flex-asjs.git;a=tree;f=framework
>> >> >s/js/FlexJS;h=868b43d18106fcb21b8b598ae60b96ddaf447d67;hb=develop
>> >> >
>> >> Correct. The libs folder is not in the repo as it contains the
>>output
>> >> from cross-compiling the as files in the
>frameworks/as/projects/FlexJSJX
>> >> folder.
>> >>
>> >> But it should get created if you run ant in the repo, and it should
>>be
>> >>in
>> >> the release package in the nightly builds.
>> >>
>> >> -Alex
>> >
>> >Well, that is what I am seeing here as well. Which brings me back to
>>my
>> >original question: how do I get my required change into BarChart.js?
>> >
>> >Maybe you need to explain like I'm 5 :-)
>> The confusing part to me is that my copy of BarChart.js does not have a
>> createElement method in it. I'm wondering if you're building
>> BarChartExample with out-of-date launch configs that are picking up an
>> older hand-written BarChart.js.
>
>It does not in my copy as well. I want to add this method to BarChart.js.
>
>I just added that method to the BarChart.js file in the bin/js-debug
>folder, which seems to fix the issue.
>
>We on the same page now?
>
>Om
>
>>
>> -Alex
>>
