Hey,
I have to admit, after this last week, I am not on my game. My kids
finally decided to share what seems to be the flu, although I feel
like I am in limbo with really getting sick, so my head and focus is
being affected. :)
I need to look at what you have done. But, there is a philosophy I
have been following with this and it goes;
"Don't make a dependency between emitting methods"
HEHE This means, I think state is fine if you are creating it or
"memoizing" the state for calls that happen int the traversing method.
It seems like your accessor memory deals with that method every time
it's called right? Or are other methods dependent on what you are
saving there?
Remember the problem we have with the classDefinition and testing a
method below a visit method that set that state? We couldn't unit test
it. I am a weird person when you met me because I honestly believe in
"units" and that keeping true abstraction by testing units is the only
way to save headaches in the future.
That being said, can we do things to "get it done" or should we take a
bit more time to find that solution that satisfies the unit approach,
which is just good encapsulation.
Sorry for all the quotes, just trying to make a point.
Anyway, let me look and give you my opinion.
Mike
Quoting Erik de Bruin <e...@ixsoftware.nl>:
Hi,
I'm aware we're trying to keep a state-less thing going with FJx, but
I ran into an issue that I'm not sure how to solve without adding some
kind of storage (private variable) on the 'goog' emitter.
The thing is that a property has/can have both a getter and a setter
accessor. For a full 'goog' implementation, in addition to emitting
'Object.defineProperty' for each, we also want to add a property
declaration on the prototype, to set the type. We want to add this
declaration only once, so my solution is to 'remember' if I already
added it in a private variable, since I know of no other way of
checking if I have already written something to the output.
Am I doing it right?
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
