Hi Rosen: > -----Original Message----- > From: Xu, Rosen > Sent: Tuesday, April 17, 2018 11:03 AM > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.x...@intel.com>; Zhang, Helin > <helin.zh...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Wu, Jingjing > <jingjing...@intel.com> > Subject: [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at > device disable > > v3 updates: > =========== > - Move modification from device close to device disable > - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous, > so unicast/multicast promiscuous disable should set before reset. > > v2 updates: > =========== > - Add more comments
Version log can be added after ---, so it will not be included by commit log. > > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit > doesn't disable promiscuous mode, this will cause vlan filter set by Kernel > Driver will not take effect. > > This patch will fix it, add promiscuous disable at device disable. > > Signed-off-by: Rosen Xu <rosen...@intel.com> > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 031c706..40012b0 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2288,6 +2288,8 @@ static int eth_i40evf_pci_remove(struct > rte_pci_device *pci_dev) > > i40evf_dev_stop(dev); > i40e_dev_free_queues(dev); I think it's better to add some comment here, since this is a workaround solution and it is not the normal way we disable promiscuous mode, people need to be noticed here. Regards Qi > + i40evf_dev_promiscuous_disable(dev); > + i40evf_dev_allmulticast_disable(dev); > i40evf_reset_vf(hw); > i40e_shutdown_adminq(hw); > /* disable uio intr before callback unregister */ > -- > 1.8.3.1
