On Wed, Apr 11, 2018 at 12:30:07PM +0530, Hemant Agrawal wrote: > > > On 4/10/2018 7:49 PM, Richardson, Bruce wrote: > > Resend, fixing "To" recipients. > > > > > -----Original Message----- > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Tuesday, April 10, 2018 3:17 PM > > > To: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > > Cc: dev@dpdk.org; herbert.g...@arm.com; pbhagavat...@caviumnetworks.com; > > > hemant.agra...@nxp.com; sta...@dpdk.org; jerin.ja...@caviumnetworks.com > > > Subject: Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction > > > level support > > > > > > On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: > > > > The make based build system has crc+crypto instruction support for the > > > > default arm64 build. > > > > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 > > > > > > > > This patch fixes the disparity with meson build flags for armv8. > > > > As a bonus, This patch fixes the following errors with ip_pipeline > > > > example application. > > > > > > > > Assembler messages: > > > > Error: selected processor does not support `crc32cx w3,w3,x0' > > > > > > > > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for > > > > ARM") > > > > > > > > Cc: herbert.g...@arm.com > > > > Cc: pbhagavat...@caviumnetworks.com > > > > Cc: bruce.richard...@intel.com > > > > Cc: hemant.agra...@nxp.com > > > > Cc: sta...@dpdk.org > > > > > > > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > > > --- > > > > > > Hemant, Shreyansh, Herbert, > > > > > > any issues with this patch on your side? Can one of you please ack it. It > > > allows use of "-Dexamples=all" when doing cross-builds for all the > > > different arm targets in the config dir. Without it, ip_pipeline fails to > > > build for many of the targets. > > > > > > /Bruce > > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com>
Applied to dpdk-next-build. Thanks, /Bruce
