Hi,
> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Wednesday, April 4, 2018 4:08 PM
> To: dev@dpdk.org
> Cc: Tan, Jianfeng <jianfeng....@intel.com>; Pattan, Reshma
> <reshma.pat...@intel.com>
> Subject: [PATCH v2] pdump: change to use generic multi-process channel
>
> The original code replies on the private channel for primary and secondary
> communication. Change to use the generic multi-process channel.
>
> Note with this change, dpdk-pdump will be not compatible with old version
> DPDK applications.
>
> Cc: reshma.pat...@intel.com
>
> Signed-off-by: Jianfeng Tan <jianfeng....@intel.com>
> ---
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 0c696f7..d55fd05 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -153,3 +153,7 @@ Deprecation Notices
> be added between the producer and consumer structures. The size of the
> structure and the offset of the fields will remain the same on
> platforms with 64B cache line, but will change on other platforms.
> +
> +* pdump: As we changed to use generic IPC, ``rte_pdump_set_socket_dir``
> +will be
> + deprecated and removed in subsequent release; the parameter, path, of
> + ``rte_pdump_init`` will also be removed.
Do we need to mention about deprecation of below enums too?
enum rte_pdump_socktype {
RTE_PDUMP_SOCKET_SERVER = 1,
RTE_PDUMP_SOCKET_CLIENT = 2
};
Thanks,
Reshma
