On 1/13/2016 4:49 PM, stephen at networkplumber.org (Stephen Hemminger) wrote: > On Wed, 13 Jan 2016 15:07:08 +0000 > Bruce Richardson <bruce.richardson at intel.com> wrote: > >> So, while the two-tab indent may look "a bit weird" it does solve the two >> issues >> above. I believe practical benefits should override initial impressions. [It >> took >> me a while to get used to also, but now I very much like it as a style.] > > I don't think that deviating from kernel style for this case is justified.
This is very old patch still sitting in patchwork, re-visiting it mainly to be able to clean the patchwork. This is a syntax change request and although I have my personal preferences I would be OK with whatever decided. Currently there is already a decided syntax, changing it after this point will cause either mixed usage or a big syntax cleanup patch. I think both are not good. I am for continue whatever documented in current DPDK coding style doc, hence NAK from my side. Thanks, ferruh