On 2/6/2018 9:22 AM, Rahul Lakkireddy wrote: > On Monday, February 02/05/18, 2018 at 22:39:55 +0530, Ferruh Yigit wrote: >> On 2/4/2018 6:06 AM, Rahul Lakkireddy wrote: >>> From: Kumar Sanghvi <kuma...@chelsio.com> >>> >>> Add firmware API for updating RSS hash configuration and key. Move >>> RSS hash configuration from cxgb4_write_rss() to a separate function >>> cxgbe_write_rss_conf(). >>> >>> Also, rename cxgb4_write_rss() to cxgbe_write_rss() for consistency. >>> >>> Original work by Surendra Mobiya <suren...@chelsio.com> >>> >>> Signed-off-by: Kumar Sanghvi <kuma...@chelsio.com> >>> Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> >>> --- >>> doc/guides/nics/cxgbe.rst | 2 + >>> doc/guides/nics/features/cxgbe.ini | 1 + >>> doc/guides/rel_notes/release_18_02.rst | 3 ++ >>> drivers/net/cxgbe/base/adapter.h | 4 +- >>> drivers/net/cxgbe/base/common.h | 3 ++ >>> drivers/net/cxgbe/base/t4_hw.c | 73 +++++++++++++++++++++++++++ >>> drivers/net/cxgbe/base/t4_regs.h | 25 +++++++++ >>> drivers/net/cxgbe/base/t4fw_interface.h | 89 >>> +++++++++++++++++++++++++++++++++ >>> drivers/net/cxgbe/cxgbe.h | 2 + >>> drivers/net/cxgbe/cxgbe_ethdev.c | 32 ++++++++++++ >>> drivers/net/cxgbe/cxgbe_main.c | 79 ++++++++++++++++++++++------- >>> 11 files changed, 295 insertions(+), 18 deletions(-) >> >> I tend to get driver patches even after integration deadline, mainly because >> of >> their limited scope. >> But since these are new features, submitted just before rc3, adding with >> questions in first patch, I am for postponing this patchset to next release >> and >> do more review, what do you think? > > Does dpdk-next-net tree work similar to linux "next" trees? I mean does > it represent the next release (DPDK 18.05-rc1) merge window? Can we > explicitly mention in Patch title which tree it is targeted for viz. > dpdk or dpdk-next-net?
Hi Rahul, It is not like Linux next trees, this is more like Dave's net tree. In dpdk responsibilities split into sub-trees, and all target current release, patches merged into sub-trees and pulled by main tree in integration deadline. All network drivers and ethdev abstraction layer patches goes into next-net sub-tree. Briefly overall process is [1]: - A new feature needs to be sent before proposal deadline, this can be a full version of the set or RFC. Proposal deadline for the release announced in https://dpdk.org/dev/roadmap - After that point code reviews done and new versions sent till integration deadline. Accepted patches are integrated to release candidate 1 (rc1). Of course patch can be reviewed and merged without waiting integration deadline. If a patch not get an approval and merge into tree in integration deadline, most probably it won't go into release. - Fixes can be sent from beginning of release to rcX. Only latest rcX mostly for the fixes on features introduced in that release. - After rc1, code tested and fixes sent for found defects. No new feature expected after rc1. - We go mostly to rc3 or rc4 before release. [1] Thomas, please correct me if I missed something. And this needs to be documented indeed. > > Thanks, > Rahul >
