> -----Original Message----- > From: Van Haaren, Harry > Sent: Monday, January 29, 2018 5:38 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry <harry.van.haa...@intel.com>; tho...@monjalon.net; > Varghese, Vipin <vipin.vargh...@intel.com> > Subject: [PATCH v3 3/4] app/pdump: call eal cleanup before exit > > This patch adds a call to the newly introduced cleanup() function just before > quitting the pdump app. > > Adding this function call before quitting from a secondary processes is > important, as otherwise it will leak hugepage memory. For a secondary process > that is run multiple times, this could cause hugepage memory to become > depleted and stop a secondary process from starting. > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > --- > > v3: > - Rework to new cleanup() function name (Thomas) > > Cc: tho...@monjalon.net > Cc: vipin.vargh...@intel.com > --- > app/pdump/main.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/app/pdump/main.c b/app/pdump/main.c index 0f70c75..50772cb > 100644 > --- a/app/pdump/main.c > +++ b/app/pdump/main.c > @@ -882,5 +882,10 @@ main(int argc, char **argv) > /* dump debug stats */ > print_pdump_stats(); > > + ret = rte_eal_cleanup(); > + if (ret) > + printf("Error from rte_eal_cleanup(), %d\n", ret); > + > + > return 0; > } > -- > 2.7.4
Tested with static and dynamic library on Linux Acked-by: Vipin Varghese <vipin.vargh...@intel.com>