> -----Original Message----- > From: Richardson, Bruce > Sent: Friday, January 26, 2018 2:50 PM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Zhang, Roy > Fan <roy.fan.zh...@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com>; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length > > > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Friday, January 26, 2018 2:44 PM > > To: Zhang, Roy Fan <roy.fan.zh...@intel.com> > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > <pablo.de.lara.gua...@intel.com>; sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length > > > > The coverity issue was not completely fixed, since strncpy should be > > called with max length - 1. > > > > Coverity issue: 143431 > > Fixes: d040aca67170 ("crypto/scheduler: fix strings not null > > terminated") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> > > Use "snprintf", please, to fix these errors sanely without having to worry > about off-by-one issues! > > /Bruce
Thanks for the comment. Will send a v2 shortly. Pablo
