Your comments about split it totally make sense ,no doubt that, but my question is that if split api with the funcational , so the function part should be set null implement or stake. Any other good idea or tip for that.
Best regards, Jeff Guo -----Original Message----- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, January 9, 2018 7:45 PM To: Guo, Jia <jia....@intel.com> Cc: Mordechay Haimovsky <mo...@mellanox.com>; dev@dpdk.org; step...@networkplumber.org; Richardson, Bruce <bruce.richard...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; gaetan.ri...@6wind.com; Ananyev, Konstantin <konstantin.anan...@intel.com>; shreyansh.j...@nxp.com; Wu, Jingjing <jingjing...@intel.com>; Zhang, Helin <helin.zh...@intel.com>; Van Haaren, Harry <harry.van.haa...@intel.com> Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug 09/01/2018 12:39, Guo, Jia: > So, how can separate the patch into more small patch, use stake or null > implement in function. I think we should consider if it is a economic way > now, if I could explain more detail in code for you all not very familiar the > background? I have sent v8, please check, thanks all. The v8 is not split enough. Please try to address all my comments.