> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday 11 December 2017 19:00
> To: Mokhtar, Amr <amr.mokh...@intel.com>; dev@dpdk.org
> Cc: tho...@monjalon.net; Burakov, Anatoly <anatoly.bura...@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Power, Niall
> <niall.po...@intel.com>; Macnamara, Chris <chris.macnam...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3 2/5] bbdev: PMD drivers (null/turbo_sw)
>
> On 12/7/2017 1:40 PM, Amr Mokhtar wrote:
> > - bbdev 'null' PMD enabled by default
> > - bbdev 'turbo_sw' PMD disabled by default
>
> Can you please separate PMDs into their own patches.
>
> > - 'turbo_sw' requires the external FLEXRAN SDK libraries
> >
> > Signed-off-by: Amr Mokhtar <amr.mokh...@intel.com>
>
> <...>
>
> > +static const struct rte_bbdev_ops pmd_ops = {
> > + .setup_queues = NULL,
> > + .intr_enable = NULL,
> > + .start = NULL,
> > + .stop = NULL,
> > + .close = NULL,
>
> No need to set NULL ones.
>
> <...>
>
> > +RTE_PMD_REGISTER_VDEV(DRIVER_NAME, bbdev_null_pmd_drv);
> > +RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_null_pmd);
>
> No need to add ALIAS macro, it is for backward compatibility.
>
> > +RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME,
> > + BBDEV_NULL_MAX_NB_QUEUES_ARG"=<int> "
> > + BBDEV_NULL_SOCKET_ID_ARG"=<int>");
> > +
> > +int bbdev_logtype;
> > +RTE_INIT(null_bbdev_init_log);
> > +static void
> > +null_bbdev_init_log(void)
> > +{
> > + bbdev_logtype = rte_log_register("pmd.null_bbdev");
>
> What about two layer hierarchy in logtype name, "pmd.bbdev.null" ?
>
> <...>
Agree on all that..
No further comments.
Thanks,
Amr
