On 12/7/2017 1:40 PM, Amr Mokhtar wrote: > - Full test suite for bbdev > - Test App works seamlessly on all PMDs registered with bbdev > framework > - A python script is provided to make our life easier
Can you please describe what the script is for? > - Supports execution of tests by parsing Test Vector files Can you please describe what are test vector files? > - Test Vectors can be added/deleted/modified with no need for > re-compilation > - Various Tests can be executed: > (a) Throughput test > (b) Offload latency test > (c) Operation latency test > (d) Validation test > (c) Sanity checks > > Signed-off-by: Amr Mokhtar <amr.mokh...@intel.com> <...> > +include $(RTE_SDK)/mk/rte.vars.mk > + > +ifeq ($(CONFIG_RTE_TEST_BBDEV),y) You don't need this ifdef I think, although I can see testpmd has it ... > + > +# > +# library name > +# > +APP = testbbdev > + > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > + > +# > +# all sources are stored in SRCS-y > +# > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += main.c > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev.c > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_perf.c > +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_vector.c If you remove above wrapping ifdef, you may use CONFIG_RTE_TEST_BBDEV instead. <...> > +int > +unit_test_suite_runner(struct unit_test_suite *suite) Is test-bbdev application a suit of test cases? What is the benefit of having separate application comparing adding unit tests to test/ folder? <...>
