On 11/30/2017 5:10 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <ravi1.ku...@amd.com>
<...>
> + /*
> + * For secondary processes, we don't initialise any further as primary
> + * has already done this work.
> + */
> + if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
> + PMD_DRV_LOG(ERR, "SECONDARY PROCCESS NOT SUPPORTED");
> + return -EINVAL;
Do you want to return error here?
rte_eth_dev_pci_generic_probe() already calls rte_eth_dev_attach_secondary(),
just returning here can work for secondary process.
> + }
> + pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
> + pdata->pci_dev = pci_dev;
> + rte_eth_copy_pci_info(eth_dev, pci_dev);
rte_eth_copy_pci_info() already called by rte_eth_dev_pci_generic_probe()
<...>
> + eth_dev->dev_ops = NULL;
> + eth_dev->rx_pkt_burst = NULL;
> + eth_dev->tx_pkt_burst = NULL;
> +
> + /*Clear macaddres at time of dev init*/
> + eth_dev->data->mac_addrs = NULL;
> + eth_dev->data->hash_mac_addrs = NULL;
None of these set yet, you can add these when they are initiazed, and this helps
to trace matching init / unints.
<...>
> +#define PMD_INIT_LOG(level, fmt, args...) \
> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args)
Can you please swith this to dynamic logging, currently only i40e has sample
usage for it.
<...>
> @@ -0,0 +1,4 @@
> +DPDK_17.11 {
DPDK_18.02
<...>
