Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option

[Olivier MATZ]

On Thu, Dec 07, 2017 at 07:37:14PM +0530, Pavan Nikhilesh Bhagavatula wrote:
> Hi Oliver,
> 
> Thanks for the review.
> 
> On Thu, Dec 07, 2017 at 02:21:21PM +0100, Olivier MATZ wrote:
> > On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote:
> > > --- a/test/test/test.h
> > > +++ b/test/test/test.h
> > > @@ -204,7 +204,7 @@ struct unit_test_case {
> > >
> > >  #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 }
> > >
> > > -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
> > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > >  #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, 
> > > buf, len)
> > >  #else
> > >  #define TEST_HEXDUMP(file, title, buf, len) do {} while (0)
> >
> > For drivers, it looks correct to replace RTE_LOG_LEVEL by
> > RTE_LOG_DP_LEVEL, from what I see it's about dataplane logs.
> >
> > For l3fwd, I'm less sure, but it could make sense too.
> >
> > For test, I think we should replace TEST_HEXDUMP() by a function
> > that checks the runtime log level instead of relying on RTE_LOG_DP_LEVEL.
> > I can submit a patch for this.
> 
> Agreed.

Please see:
http://dpdk.org/ml/archives/dev/2017-December/083295.html

By the way, if you do another version on top of this patchset,
I think you can also do the following replacement for consistency:

  --- a/lib/librte_flow_classify/rte_flow_classify.c
  +++ b/lib/librte_flow_classify/rte_flow_classify.c
  @@ -685,7 +685,7 @@ static void
   librte_flow_classify_init_log(void)
   {
          librte_flow_classify_logtype =
  -               rte_log_register("librte.flow_classify");
  +               rte_log_register("lib.flow_classify");
          if (librte_flow_classify_logtype >= 0)
                  rte_log_set_level(librte_flow_classify_logtype, RTE_LOG_INFO);
   }
  diff --git a/lib/librte_member/rte_member.c b/lib/librte_member/rte_member.c
  index cc9ea84ae..84354cc38 100644
  --- a/lib/librte_member/rte_member.c
  +++ b/lib/librte_member/rte_member.c
  @@ -330,7 +330,7 @@ RTE_INIT(librte_member_init_log);
   static void
   librte_member_init_log(void)
   {
  -       librte_member_logtype = rte_log_register("librte.member");
  +       librte_member_logtype = rte_log_register("lib.member");
          if (librte_member_logtype >= 0)
                  rte_log_set_level(librte_member_logtype, RTE_LOG_DEBUG);
   }


Thanks,
Olivier