On Wed, Nov 22, 2017 at 02:58:04PM +0530, Pavan Nikhilesh wrote: > Update legacy log types regex strings used for registering dynamic logs. > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > --- > Note: > This patchset is based on patch set > http://dpdk.org/dev/patchwork/patch/31443/ > followed by ml discussion > http://dpdk.org/ml/archives/dev/2017-November/081953.html > > lib/librte_eal/common/eal_common_log.c | 39 > +++++++++++++++++----------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_log.c > b/lib/librte_eal/common/eal_common_log.c > index e894b75ec..fa9ac7247 100644 > --- a/lib/librte_eal/common/eal_common_log.c > +++ b/lib/librte_eal/common/eal_common_log.c > @@ -219,26 +219,27 @@ struct logtype { > }; > > static const struct logtype logtype_strings[] = { > - {RTE_LOGTYPE_EAL, "eal"}, > - {RTE_LOGTYPE_MALLOC, "malloc"}, > - {RTE_LOGTYPE_RING, "ring"}, > - {RTE_LOGTYPE_MEMPOOL, "mempool"}, > - {RTE_LOGTYPE_TIMER, "timer"}, > + {RTE_LOGTYPE_EAL, "lib.eal"}, > + {RTE_LOGTYPE_MALLOC, "lib.malloc"}, > + {RTE_LOGTYPE_RING, "lib.ring"}, > + {RTE_LOGTYPE_MEMPOOL, "lib.mempool"}, > + {RTE_LOGTYPE_TIMER, "lib.timer"},
[...] I agree it's much better to have the library prefixed by "lib.". Reviewed-by: Olivier Matz <olivier.m...@6wind.com>