> -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, December 7, 2017 6:09 AM > To: Mody, Rasesh <rasesh.m...@cavium.com>; dev@dpdk.org > Cc: Shaikh, Shahed <shahed.sha...@cavium.com>; Dept-Eng DPDK Dev <Dept- > engdpdk...@cavium.com> > Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: add configuration for udp > port tunnel type > > On 11/24/2017 12:35 PM, Rasesh Mody wrote: > > From: Shahed Shaikh <shahed.sha...@cavium.com> > > > > Replace rx_vxlan_port command with rx_tunnel_udp_port to support both > > VXLAN and GENEVE udp ports. > > Also updates tunnel_filter command to accept "geneve" argument, can you > please separate to another patch. > > And to prevent these patches hold PMD patches, you can send a new version of > the patchset splitting qede PMD patches into their own patchset.
Sure. We'll send separate patchset for qede PMD. > > > > > Signed-off-by: Shahed Shaikh <shahed.sha...@cavium.com> > > --- > > app/test-pmd/cmdline.c | 28 +++++++++++++++++++--------- > > 1 file changed, 19 insertions(+), 9 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > f71d963..4b5a8cd 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -402,11 +402,11 @@ static void cmd_help_long_parsed(void > *parsed_result, > > "imac-tenid|imac|omac-imac-tenid|oip|iip) (tenant_id) > (queue_id)\n" > > " remove a tunnel filter of a port.\n\n" > > > > - "rx_vxlan_port add (udp_port) (port_id)\n" > > - " Add an UDP port for VXLAN packet filter on a > port\n\n" > > + "rx_tunnel_udp_port add vxlan|geneve (udp_port) > (port_id)\n" > > Not sure about "rx_tunnel_udp_port" command. > > What do you think something like: > "port config (port_id) udp_tunnel_port add|rm vxlan|geneve (udp_port)" > > to expand ""port config (port_id) ..." command instead of introducing a new > one? Makes sense. I'll update port_config command. Thanks, Shahed
